Leonardo Garcia
660178abe1
Permit to delete a running VM.
...
The VM will be forced off before being deleted.
(crobinso: fix a minor pylint violation)
2013-06-18 08:49:18 -04:00
Cole Robinson
44328b1507
Fix some pylint
2013-06-17 20:17:20 -04:00
Leonardo Garcia
18bf5f508d
Add delete VM option in console viewer.
...
(crobinso: Fix a minor pep8 warning)
2013-06-17 20:07:37 -04:00
Cole Robinson
30d509feec
delete: Tweak 'are you sure' message for storage deletion
2013-06-17 13:41:32 -04:00
Cole Robinson
b339295fb5
Sigh, fix previous commit.
2013-06-14 16:32:48 -04:00
Cole Robinson
ea9fadac78
config: Fix changing tick timeout on the fly
2013-06-14 16:22:33 -04:00
Cole Robinson
0283750b9d
Fix USB test failures with latest libvirt
2013-06-14 14:58:52 -04:00
Cole Robinson
3889bc480b
asyncjob: Fix dialog closing and progress bar pulsing
...
After the recent cleanups
2013-06-14 14:28:04 -04:00
Cole Robinson
8914a61689
Fix exiting app if asyncjobs are running
2013-06-14 11:24:52 -04:00
Cole Robinson
b5baebf24c
asyncjob: Only close window if operation completes.
2013-06-14 11:19:22 -04:00
Cole Robinson
cdde7e1d9f
asyncjob: Some code reorg
...
Privatize a bunch of things, move code around to be grouped consistently.
2013-06-14 11:18:12 -04:00
Cole Robinson
2b3604ceeb
systray: Fix pylint from appindicators
2013-06-14 11:03:48 -04:00
Cole Robinson
8e0a181cc6
asyncjob: Explicitly pass callbacks to vmmCreateMeter
2013-06-14 10:45:20 -04:00
Eric Shattow
f2c0a77e3e
AppIndicator3 required with Gtk3 usage
...
$ ./virt-manager --debug
/usr/lib/python2.7/dist-packages/gi/overrides/GLib.py:53:
PyGIDeprecationWarning: threads_init longer needs to be called. See:
https://bugzilla.gnome.org/show_bug.cgi?id=686914
PyGIDeprecationWarning)
2013-06-12 13:10:56,977 (cliutils:75): virt-manager startup
2013-06-12 13:10:56,978 (virt-manager:199): Launched as:
['./virt-manager', '--debug']
2013-06-12 13:10:56,978 (virt-manager:200): virt-manager version: 0.9.100
2013-06-12 13:10:56,978 (virt-manager:201): virtManager import:
<module 'virtManager' from
'/home/es/software/pubscm/virt-manager/virtManager/__init__.pyc'>
2013-06-12 13:10:57,167 (virt-manager:247): GTK version: 3.8.2
/usr/lib/python2.7/dist-packages/gobject/constants.py:24: Warning:
g_boxed_type_register_static: assertion 'g_type_from_name (name) == 0'
failed
import gobject._gobject
/usr/lib/python2.7/dist-packages/gtk-2.0/gtk/__init__.py:40: Warning:
specified class size for type 'PyGtkGenericCellRenderer' is smaller
than the parent type's 'GtkCellRenderer' class size
from gtk import _gtk
/usr/lib/python2.7/dist-packages/gtk-2.0/gtk/__init__.py:40: Warning:
g_type_get_qdata: assertion 'node != NULL' failed
from gtk import _gtk
Segmentation fault (core dumped)
2013-06-14 09:09:08 -04:00
Cole Robinson
8a0bee44dc
packagekit: Allow cancelling package search
2013-06-13 17:37:12 -04:00
Cole Robinson
1c22ea92df
engine: Close packagekit dialog before connecting to libvirt
...
We are bunching up a slew of hefty operations, split things up a bit
so the UI has a change to catchup.
2013-06-13 17:35:48 -04:00
Cole Robinson
e2435b6d02
asyncjob: Simplify registering a cancel callback
2013-06-13 17:05:33 -04:00
Cole Robinson
04f0113c2d
libguestfs: Work around a pylint error
...
Not sure why it's triggering a warning here, thinks the return result
is a dict()
2013-06-13 16:12:55 -04:00
Cole Robinson
cbe8665948
libguestfs: Don't try to create icon if none found
2013-06-13 16:10:44 -04:00
Cole Robinson
f3751e6fe9
libguestfs: Start the inspection thread earlier
2013-06-13 16:04:16 -04:00
Cole Robinson
5a46e7420a
libguestfs: Drop all version checks
...
Now that virt-manager requires very modern versions of gtk, it's
quite unlikely that we will even run on a system with an old
libguestfs version, so don't bother checking versions.
2013-06-13 16:04:16 -04:00
Cole Robinson
0c9552bccb
spec: Drop libguestfs conditional
...
We will likely never explicitly depend on it.
2013-06-13 15:56:41 -04:00
Cole Robinson
91a97d439c
manager: Fix loading libguestfs OS icons (bz 905238)
2013-06-13 15:54:12 -04:00
Cole Robinson
4da8c604f8
osdict: Add Fedora 19
2013-06-13 14:58:59 -04:00
Cole Robinson
8804e59518
error: Minor improvement to error dialog logging
2013-06-13 14:12:19 -04:00
Cole Robinson
c3d54cbd20
manager: Only log 'Closing manager' if it's not already closed
...
Same with 'Showing manager'
2013-06-13 14:12:19 -04:00
Cole Robinson
b8d3bde4a2
autodrawer: Fix a gtk assertion at app shutdown
2013-06-13 14:10:59 -04:00
Cole Robinson
eeba8b6d0b
autodrawer: Fix fullscreen toolbar centering on F19
...
child_get_property appears to be busted.
2013-06-13 13:55:43 -04:00
Cole Robinson
3da7f55462
create-interface: Fix VLAN tag upper limit
...
https://bugzilla.redhat.com/show_bug.cgi?id=863322
2013-06-12 21:27:47 -04:00
Cole Robinson
436a5bfc8b
serialcon: Fix tracebacks when we get EOF on stream
2013-06-12 21:10:52 -04:00
Cole Robinson
4201ef9e68
details: Multiple screenshot improvements and fixes
...
- Fix screenshot after gtk3 conversion
- Report errors to the user if something goes wrong
- Drop the 'screenshot saved' success dialog
- Capture the screenshot data before asking for the file path, so things
aren't out of date.
- Give a default recommended screenshot path to save.
First bit fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=969410
2013-06-12 21:00:11 -04:00
Martin Kletzander
77fb38e602
serialcon: Close the console at the end of the stream
...
When LXC guest was shut down while its console was open, virt-manager
got stuck in a loop due to the fact that the readable event was not
properly removed from the callback. Mimicking the behavior from
libvirt's tolls/console.c file, this patch properly closes the console
in case stream.recv() returns empty string.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=968896
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-12 11:10:30 +02:00
Martin Kletzander
1ca9d6ebd2
Update supported models (bz 959888)
2013-06-12 10:49:30 +02:00
Cole Robinson
ff297777cc
details: Don't traceback if VM deleted with open details window
...
When a VM is undefined, whether explicitly through virt-manager or behind
our back, we close and cleanup any associated vmmDetails windows. However
there's a race here: if the details window is the last remaining top
level window, cleanup() is called twice which tracebacks.
Fix this by dispatching the exit_app routine in an idle callback, to
avoid racing with any window delete routines.
Reported-by: Leonardo Garcia <lagarcia@br.ibm.com>
2013-06-11 11:02:56 -04:00
Leonardo Garcia
665375db1b
Fix progres bar output bug in virt-clone.
...
The loop in StorageVolume._progress_thread that updates the cloning progress
bar has a call to sleep in the beginning of the loop which causes issues with
the progress bar. An example output (shorten to use less columns) with the
problem:
[laggarcia@fedora18 virt-manager]$ ./virt-clone --connect
qemu+ssh://root@192.168.122.1/system --original=Fedora18-test --auto-clone
root@192.168.122.1's password:
Allocating 'Fedora18-test-clone.img' | 20 GB 00:00:56
Clone 'Fedora18-test-clone' created successfully.
[laggarcia@fedora18 virt-manager]$ ' 4% [===- ] -300039887.4 B/s | 881 MB --:--:-- ETA
As the StorageVolume._progress_thread sleeps for one second when the loop
starts, it might occur that, when the cloning procedure finishes, the loop is
still awaiting to update the progress bar, which will cause a bad progress bar
update.
This simple fix solves this issue.
2013-06-10 10:20:35 -04:00
Leonardo Garcia
576721d8b2
Remove unnecessary nested try block.
...
This nested block has been added by python-virtinst's commit
4a9664634dd5ae65ed92b59b1f1543633c7d8112, aparently without need.
2013-06-10 09:55:17 -04:00
Cole Robinson
0f8ea6eaa6
baseclass: Clean up non-standard __init__
...
Only used by console.py, make it more explicit.
2013-06-08 19:25:36 -04:00
Martin Kletzander
e407c2eac9
Make pylint a bit happier
...
Various fixes for some pylint and pep8 warnings/errors which are
fixable and cleanup few lines with that.
2013-06-05 10:19:54 +02:00
Martin Kletzander
74aa8c8a58
Generate valid UUIDs according to RFC4122
...
Similar change to that made in libvrt's upstream commit 396c4d34.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=963161
2013-06-05 10:19:53 +02:00
Leonardo Garcia
6a1ad46978
Do not show manager window at startup if user requested to show any other window from command line.
2013-05-30 11:25:44 -04:00
Leonardo Garcia
efd5401378
connect_to_uri is not a public method.
...
connect_to_uri is only called from engine.py.
2013-05-30 11:25:44 -04:00
Cole Robinson
2274e233e0
Fix PCI commit, add CCID controller as well
2013-05-28 10:55:40 -04:00
Cole Robinson
a5a9f8e3bd
Fix a couple more typos pointed out by translator
2013-05-27 20:04:55 -04:00
Cole Robinson
448730306e
virtinst: Add pretty name for PCI controller
2013-05-27 19:45:14 -04:00
Cole Robinson
de1695b2a9
setup.py: Change default-graphics from spice->vnc
...
It's still changeable with 'configure', but this makes the unconfigured
default in line with what modern distros should use.
2013-05-27 18:51:12 -04:00
Cole Robinson
14578fc2c3
details: Fix changing cirrus->QXL for active VM (bz 928882)
2013-05-27 18:50:25 -04:00
Cole Robinson
799bca76f3
spec: Make sure libvirt-daemon-config-network is installed (bz 950329)
2013-05-27 18:41:40 -04:00
Cole Robinson
a0961e35b7
spec: Unconditionally add default-graphics=spice (bz 965864)
2013-05-27 18:40:11 -04:00
Cole Robinson
7f621db08f
Fix a few wordings recommended by a translator
2013-05-27 13:41:45 -04:00
Cole Robinson
4b8d28df1d
Update translations
2013-05-27 13:41:38 -04:00