So I was confused here and completely missed that GtkApplication is
meant to handle the common case of invoking actions in an existing
app instance. So drop the manual dbus server and use the simpler
Gtk support.
Fix a bunch of other errors in this area too
Originally we didn't add this since arm vexpress virtio only had 4
virtio-mmio slots. But the now-common -M virt target has 32 slots,
so we aren't starved.
Traceback (most recent call last):
File "/home/crobinso/src/virt-manager/virtManager/details.py", line 1257, in switch_page
self.console.details_refresh_can_fullscreen()
File "/home/crobinso/src/virt-manager/virtManager/console.py", line 965, in details_refresh_can_fullscreen
return self._refresh_can_fullscreen()
File "/home/crobinso/src/virt-manager/virtManager/console.py", line 464, in _refresh_can_fullscreen
self.widget("control-fullscreen").set_sensitive(allow_fullscreen)
TypeError: Argument 1 does not allow None as a value
This allows virt-manager command line that launch windows to work for an
existing virt-manager instance. This is handy for scripting, and giving
other apps a reasonable way to launch a virt-manager VM window for
example.
Remove the lookup counter from _progress_thread, it's not necessary, the
loop is terminated by _install_finished boolean.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1270277
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This UI exposed the old NUMA allocation policy detailed in the last commit.
It's very much sub-optimal, and should be removed.
Manual cpuset configuration is also quite uncommon and not really something
worth exposing in the UI. It can easily be done from the command line
with virt-xml.
If people complain, I'd consider adding a checkbox for vcpu placement=auto,
or an option to do that by default for new VMs.
For many years virt-install has supported a bit of logic that maps
--cpuset=auto to a CPU pinning based on host NUMA topology; we look
for a NUMA node who's current free memory is closest to the requested
memory allocation. This isn't very useful though, since it's a one time
allocation, the conditions at VM creation time likely aren't the
conditions of the machine in the future.
Libvirt has supported a smarter option in vcpu placement=auto for a long
while, which will perform a similar operation but at every VM startup.
Convert cpuset=auto to use this functionality instead.
Add console target "sclp" for s390x ,since the newest Distro guests has
supported the console target, solve some console issues in s390x.Also
modified the test xml cover this change.
crobinso: fix the test suite output
Currently we show channel label by its name.
If we use name com.redhat.spice.0 but set it
as unix socket, the label in details keep unchanged.
This patch will set label according to device type
if we failed matching target_name
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
Since the qemu 2.4 has supported the watchdog device diag288
for s390x,so add it in the optional model list. Also modefied
the clitest xml to cover this change.
Kernel for ppc64 automatically enables serial console, there is no need
to report any warning.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1247434
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
We should detect RHEL qemu also for session connection, not only system
connection, the capabilities of both are the same.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1258691
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Add a capatilities xml file for s390x ,the capatility for IBM
Distro called KVMIBM,mainly focus on a KVM hypervious on S390x.
Also add a clitest by using virt-install.
According to xen documentation 64bit guest has to have pae enabled in
order to be able to run 64bit OS.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1267160
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Commit 3a33f341 fixed an issue, where we should remove source path for
unix channel in order to let libvirt generate new one. Add a test case
to cover this change.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
