Cédric Bosdonnat
03e827b24b
Improve container image url examples
...
Replace the docker://fedora placeholder by a tooltip that shows more of the
possible values (taken from virt-bootstrap's man page). Finding an image
that has a /sbin/init on the docker hub is rather hard, better remove
the misleading value.
2018-01-06 17:21:35 -05:00
Lin Ma
c4c78d2894
details: Show attached disk information in scsi controller page
...
It helps users to recognize controllers <-> disks mapping relationship.
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:40:30 -05:00
Lin Ma
12c5945be0
details: Disallow removing the scsi controller if disks attached to it
...
Through virt-manager, After we removed a virtio-scsi controller which
virtual disks still attach to it, Libvirt will add a LSI scsi controller
for this guest automatically and trigger a lifecycle event, virt-manager
updates and shows this new scsi controller in details panel once it got
the lifecycle event.
It may confuse user that a LSI scsi controller occurs while one removes
the virtio-scsi controller.
This patch prevents removing a scsi controller if any disks attaching to
it.
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:40:30 -05:00
Lin Ma
066b91b2a0
ui: details: Add ui for showing attached controller devices in the future
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:40:30 -05:00
Lin Ma
2c06086495
details: Rename the variable 'dev' to 'controller' in refresh_controller_page
...
Use the more appropriate name for more correctly identifies controllers.
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:01:54 -05:00
Lin Ma
75eb62fdb1
virtinst: Add pretty_desc function for device address printing
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:01:49 -05:00
Lin Ma
65db33fec0
virtinst: Add a compare_controller function for future use
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-01-06 16:01:45 -05:00
Cole Robinson
0198db6d3f
tests: cli: Skip iso test if isoinfo isn't installed
2018-01-06 15:08:23 -05:00
Cole Robinson
fe04438832
spec: Add dep on genisoimage, for isoinfo
2018-01-06 14:18:19 -05:00
Cole Robinson
c727db2380
tests: Drop --skipcli option
...
cli tests are much faster nowadays, this option isn't all that useful
2018-01-06 14:04:34 -05:00
Cole Robinson
c9ca8ab7ce
tests: test_urls: Simplify adding in local tests
...
I'll use this to scoop up local ISOs for comprehensive testing
locally.
2018-01-06 14:04:34 -05:00
Cole Robinson
c7ed34de63
tests: test_urls: Big rework
...
Move all the test cases to an .ini file. Various cleanups and
minor improvements throughout
2018-01-06 14:04:34 -05:00
Cole Robinson
26046c5948
urlfetcher: Fix detection with latest ALT media
2018-01-06 14:04:34 -05:00
Cole Robinson
a183031793
urlfetcher: More debian CD arch handling
2018-01-06 14:04:34 -05:00
Andrew Wong
a7aa02ffa9
virtinst: Use isoinfo to extract files from ISOs and block devices
2018-01-06 14:02:11 -05:00
Cole Robinson
23c9dd3ee7
tests: clitest: Add an actual stub iso for --location testing
...
And add an explicit nfs URL test
2018-01-06 14:01:44 -05:00
Chen Hanxiao
3e3ffe1e2d
pylint: remove a unnecessary pass
...
pylint complains:
Unnecessary pass statement (unnecessary-pass)
Reviewed-by: Pavel Hrdina <phrdina.redhat.com>
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-12-22 21:48:35 +08:00
Cédric Bosdonnat
0c6bcb0917
python3: fix bytes/string mess in serial console
...
Add a few encode() and decode() to convert between libvirt stream
functions expecting bytes arrays and Vte callbacks providing strings.
2017-12-20 16:09:35 -05:00
Cole Robinson
b5b2433ad5
baseclass: Fix UI file loading on py3
...
We were passing in a unicode string object, but add_from_string
depends on knowing binary length. This caused signals to not
be registered which broke reopening the details window
Just switch to add_from_file to sidestep the issue
2017-12-20 16:04:36 -05:00
Cole Robinson
c174b5509f
connection: Another py3 exception variable fix
2017-12-20 14:16:13 -05:00
Cédric Bosdonnat
60968fa259
py3: store exception variables for use outside except
...
In python3 exceptions aren't defined outside the except block. Leading
to 'UnboundLocalError: local variable 'e' referenced before assignment'
errors.
To work around this, store the local variable into one that will have a
longer life.
2017-12-20 14:13:27 -05:00
Anthony
ca3c3a5869
ui: create: fix bootstrap typo
2017-12-20 14:02:55 -05:00
Scott Garfinkle
249ff1ed36
virtio-scsi by default on power
...
Power architecture guests should default to virtio-scsi rather than spapr-scsi
Signed-off-by: Scott Garfinkle <scottgar@linux.vnet.ibm.com>
2017-12-20 13:30:45 -05:00
Lin Ma
08b2b808bd
addhardware: Remove IDE from list while adding controllers
...
Libvirt only supports built-in IDE controller so far, There is no
any case that needs us manually add an IDE controller, So remove
it from the controller list.
Signed-off-by: Lin Ma <lma@suse.com>
2017-12-20 13:15:46 -05:00
Pavel Hrdina
f3f9dd6b73
virtinst.support: fix copy&paste error
...
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-12-18 19:18:31 +01:00
Cole Robinson
4224b0926e
tests: Remove storage UUID hackery
...
In several cases we were trying to define two different pools with
the same UUID. Libvirt used to accept that but as of a recent
commit it started rejecting it for the test driver.
The UUID stuff isn't adding anything so drop it from all the test
cases and data.
2017-12-14 12:45:01 -05:00
Cole Robinson
fe59c33772
virtinst: storage: Don't generate UUID by default
...
Just let libvirt do it for us, it doesn't really add anything
2017-12-14 12:45:01 -05:00
Cole Robinson
c286593b56
virtinst: network: Don't generate UUID by default
...
Just let libvirt do it for us, it doesn't really add anything
2017-12-14 12:45:01 -05:00
Cole Robinson
8b4befae60
virtinst: Drop UUID validation
...
It's redundant as libvirt will give us these checks already, and we
aren't even testing it
2017-12-14 12:45:01 -05:00
Cole Robinson
5ac933e98a
guest: Set default rendernode= if spice gl requested
...
Since this is required to work out of the box with qemu:///system
2017-11-25 17:29:02 -05:00
Cole Robinson
bd1c6e55ad
gfxdetails: Select rendernode by default when user requests gl=on
...
Since it's required for qemu:///system to work
2017-11-25 17:28:57 -05:00
Cole Robinson
29a5e7a230
details: Remove q35 support warning (bz #1443021 )
...
It's been around long enough and in use long enough that this
isn't required anymore
2017-11-25 15:15:08 -05:00
Pavel Hrdina
b9bc3b605a
delete: undefine only persistent domain
...
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1517119
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-11-24 17:39:58 +01:00
Cole Robinson
9b58ea4e51
tests: test_urls: Update URL list
2017-11-22 17:32:20 -05:00
Andrew Wong
f836e47b70
virtinst: Fix _URLFetcher for reading files
...
_grabber() is used for both binary and text files.
2017-11-22 17:26:31 -05:00
Lin Ma
2eb455c97f
addhardware: Correctly calculate virtio-scsi controller index
...
Because sata, usb and scsi use same device prefix: sd*, They will be
included into occupied list while we add virtio-scsi disks, This is
wrong and may cause adding additional virtio-scsi controller.
How to reproduce:
1. fresh install a qemu guest.
2. add 6 virtual USB disks.
3. add disk A on scsi bus.
(then a virtio-scsi controller 0 will be added automatically)
4. add disk B on scsi bus.
5. observe.
Expected:
disk A and disk B should be connected to virtio-scsi controller 0 because
controller 0 has enough available slots.
Actual:
disk A was connected to virtio-scsi controller 0.
An additional virtio-scsi controller 1 was added and disk B was connected
to it because virt-manager thought the virtio-scsi controller 0 doesn't
have available slot.
Signed-off-by: Lin Ma <lma@suse.com>
2017-11-22 16:50:33 -05:00
Cole Robinson
7fc7e94f21
addhardware: Fix virtio-scsi controller target calculation
...
More details here: https://www.redhat.com/archives/virt-tools-list/2017-November/msg00014.html
Reported-by: Lin Ma <lma@suse.com>
2017-11-22 16:50:33 -05:00
Lin Ma
bbd6a8fd98
testdriver: add missing addrStr for scsi disk
...
Signed-off-by: Lin Ma <lma@suse.com>
2017-11-21 17:39:00 -05:00
Lin Ma
2e85ad5675
details: Show controller description + index
...
This patch and future patches can help users to better recognize which
disks connect to which scsi controllers.
Signed-off-by: Lin Ma <lma@suse.com>
2017-11-21 17:18:56 -05:00
Radostin Stoyanov
4e93ad09cb
news: Fix typo
2017-10-27 10:10:08 +02:00
Radostin Stoyanov
73de828524
systray: Remove redundant variable assignment
...
The explicit assignment of "name" is unnecessary.
2017-10-27 10:10:08 +02:00
Cole Robinson
3be78d1f3f
addhardware: Don't allow panic option where it isn't supported
...
Like aarch64, basically any arch that doesn't have an explicit panic
model
2017-10-27 09:47:38 +02:00
Cole Robinson
f7c8cf9f66
devicepanic: Don't return empty model list (bz #1505532 )
...
Callers don't expect it, and it breaks opening the addhardware dialog
for aarch64 VMs
https://bugzilla.redhat.com/show_bug.cgi?id=1505532
2017-10-27 09:42:54 +02:00
Cole Robinson
6fb5baf8a8
tests: xmlparse: explain AddRemoveDevice cases
2017-10-26 12:02:03 +02:00
Lin Ma
9e0e0dfb08
testdriver: Add vhostuser example
...
Signed-off-by: Lin Ma <lma@suse.com>
2017-10-26 11:52:26 +02:00
David Rabel
9cbf7efb16
Fix typo in virt-convert man page
...
'VMX of OVF' -> 'VMX or OVF'
2017-10-26 10:34:33 +02:00
Chen Hanxiao
4897615a1e
pylint: Replace deprecated assertEquals with assertEqual
...
pylint complain:
Using deprecated method assertEquals() (deprecated-method)
https://docs.python.org/3.3/library/unittest.html#deprecated-aliases
Method Name Deprecated alias Deprecated alias
assertEqual() failUnlessEqual assertEquals
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2017-10-22 19:24:29 +08:00
Cole Robinson
10246e0caa
tests: uitests: wire up --debug option
2017-10-21 19:41:33 -04:00
Cole Robinson
374a3779c4
urlfetcher: Write test file as binary content
...
Triggers an test_ui error otherwise:
TypeError: write() argument must be str, not bytes
2017-10-21 19:41:33 -04:00
Cole Robinson
d82022bd2c
manager: Drop python2 only cmp() usage
...
Manually implement it
2017-10-21 19:41:33 -04:00