mirror of
https://github.com/virt-manager/virt-manager.git
synced 2025-02-25 18:55:27 -06:00
2da4884962
Examples: `virt-xml MYVM --add-device --sound FOO1 --sound FOO2` is not rejected and will add 2 devices. `virt-xml MYVM --remove-device --sound opt1=FOO1 --sound opt2=FOO2` is not rejected, only the final `--sound` option is used. `virt-xml MYVM --edit --sound FOO1 --sound address.type=BAR` is not rejected. The commandlines will effectively be squashed `--sound` can be any XML option, but trying to mix and match options like `--sound` and `--disk` is always rejected. These bits are unexpected and undocument, but have been around since the beginning of virt-xml. I can see us breaking compat on these in the future (particularly the --remove-device bit), but that would need to be an explicit decision, and announced appropriately. In the mean time, we should be testing this so it doesn't accidentally regress. Signed-off-by: Cole Robinson <crobinso@redhat.com>