mirror of
https://github.com/virt-manager/virt-manager.git
synced 2025-01-08 15:13:11 -06:00
408a39a777
The reason we fork by default, is to force ssh to invoke ssh-askpass when a password is required, rather than prompt on a terminal no one is looking at. There's a more thorough explanation here: https://github.com/virt-manager/virt-manager/issues/731 With SSH_ASKPASS_REQUIRE=force, we now have a way to force ssh to use askpass in the above scenario, when ssh and libvirt are new enough. The default forking behavior has caused maintenance pain in the past, and is currently causing issues on macos: https://github.com/virt-manager/virt-manager/issues/620 Let's flip the default to `--no-fork`. The VIRT_MANAGER_DEFAULT_FORK env variable is there as an escape hatch incase I really miscalculated. I don't expect many people are depending on use of askpass either way, or if they are, they are launching virt-manager from their desktop and not a terminal, which already gives us the correct behavior AFAICT> My suspicion is barely anyone will notice, which is why I'm ok with changing this now, despite the libvirt support being brand new. If this doesn't raise any issues, then we can eventually drop the forking behavior all together. Signed-off-by: Cole Robinson <crobinso@redhat.com> |
||
|---|---|---|
| .. | ||
| virt-clone.rst | ||
| virt-install.rst | ||
| virt-manager.rst | ||
| virt-xml.rst | ||