From 033b671d0b6af47e8f6ea0b12234281b059d1381 Mon Sep 17 00:00:00 2001
From: Julien Fontanet <julien.fontanet@isonoe.net>
Date: Wed, 16 Jun 2021 09:59:07 +0200
Subject: [PATCH] fix(xo-server): limit number of xapiObjectToXo logs

See xoa-support#3830
---
 packages/xo-server/src/xo-mixins/xen-servers.mjs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/packages/xo-server/src/xo-mixins/xen-servers.mjs b/packages/xo-server/src/xo-mixins/xen-servers.mjs
index 36640b4d5..19ca27eef 100644
--- a/packages/xo-server/src/xo-mixins/xen-servers.mjs
+++ b/packages/xo-server/src/xo-mixins/xen-servers.mjs
@@ -224,7 +224,13 @@ export default class {
           objects.set(xoId, xoObject)
         }
       } catch (error) {
-        log.error('xapiObjectToXo', { error })
+        // only log the error if the object was already in `toRetry`
+        //
+        // otherwise there will be too many logs, some of them irrelevant (transient
+        // and simply due to the order objects are processed)
+        if (xapiId in toRetry) {
+          log.error('xapiObjectToXo', { error })
+        }
 
         toRetry[xapiId] = xapiObject
       }