fix(vm): hide cores per socket selector when no container (#2221)

src/common/intl/messages.js

@@ -868,6 +868,7 @@ const messages = {
   vmChooseCoresPerSocket: 'Default behavior',
   vmCoresPerSocket:
     '{nSockets, number} socket{nSockets, plural, one {} other {s}} with {nCores, number} core{nCores, plural, one {} other {s}} per socket',
+  vmCoresPerSocketNone: 'None',
   vmCoresPerSocketIncorrectValue: 'Incorrect cores per socket value',
   vmCoresPerSocketIncorrectValueSolution:
     'Please change the selected value to fix it.',

src/xo-app/vm/tab-advanced.js

@@ -178,7 +178,7 @@ class CoresPerSocket extends Component {
   _getCoresPerSocketPossibilities = createSelector(
     () => {
       const { container } = this.props
-      if (container !== undefined) {
+      if (container != null) {
         return container.cpus.cores
       }
     },
@@ -198,12 +198,14 @@ class CoresPerSocket extends Component {
     editVm(this.props.vm, { coresPerSocket: getEventValue(event) || null })
 
   render () {
-    const vm = this.props.vm
+    const { container, vm } = this.props
     const selectedCoresPerSocket = vm.coresPerSocket
     const options = this._getCoresPerSocketPossibilities()
 
     return (
       <form className='form-inline'>
+        {container != null ? (
+          <span>
             <select
               className='form-control'
               onChange={this._onChange}
@@ -237,6 +239,15 @@ class CoresPerSocket extends Component {
                 <Icon icon='error' size='lg' />
               </Tooltip>
             )}
+          </span>
+        ) : selectedCoresPerSocket != null ? (
+          _('vmCoresPerSocket', {
+            nSockets: vm.CPUs.number / selectedCoresPerSocket,
+            nCores: selectedCoresPerSocket,
+          })
+        ) : (
+          _('vmCoresPerSocketNone')
+        )}
       </form>
     )
   }