From 1c98a05b4f6958633194908255b15def5278aa7a Mon Sep 17 00:00:00 2001 From: Julien Fontanet Date: Thu, 19 Dec 2013 15:02:52 +0100 Subject: [PATCH] Do not rely on VM metrics for memory when not running. --- src/spec.coffee | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/spec.coffee b/src/spec.coffee index 50e507288..886a165b0 100644 --- a/src/spec.coffee +++ b/src/spec.coffee @@ -283,17 +283,22 @@ module.exports = (refsToUUIDs) -> address: -> null # TODO # TODO: `0` should not be used when the value is unknown. - memory: @dynamic {usage: null, size: null}, { + memory: @dynamic { + usage: null + size: get 'memory_dynamic_min' + }, { VM_metrics: { update: (metrics, UUID) -> return if UUID isnt refsToUUIDs[@generator.metrics] + # Do not trust the metrics if the VM is not running. + {power_state: state} = @value + return unless state in ['Paused', 'Running'] + @field.size = +metrics.memory_actual } } - memory_dynamic: get('memory_dynamic_min') - power_state: get('power_state') # TODO: initialize this value with `VCPUs_at_startup`.