NuKVM/xen-orchestra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(xo-web/modal/form): don't close on click or escape (#5002)

Browse Source 
See xoa-support#2469

When the user clicks outside of a form modal or presses escape, don't close the
modal as all the information they entered so far will be lost.
This commit is contained in:
Pierre Donias 2020-05-15 16:24:16 +02:00 committed by GitHub
parent d547aa8ebd
commit 1dead8b080
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.unreleased.md
View File

@ -11,6 +11,7 @@
- [XOA/licenses] Display proxy licenses (PR [#4944](https://github.com/vatesfr/xen-orchestra/pull/4944)) - [XOA/licenses] Display proxy licenses (PR [#4944](https://github.com/vatesfr/xen-orchestra/pull/4944))
- [Network selector] Display pool's name [#4885](https://github.com/vatesfr/xen-orchestra/issues/4885) (PR [#4990](https://github.com/vatesfr/xen-orchestra/pull/4990)) - [Network selector] Display pool's name [#4885](https://github.com/vatesfr/xen-orchestra/issues/4885) (PR [#4990](https://github.com/vatesfr/xen-orchestra/pull/4990))
- [Usage report] Include CSV raw data files to the sent email [#4970](https://github.com/vatesfr/xen-orchestra/issues/4970) (PR [#4979](https://github.com/vatesfr/xen-orchestra/pull/4979)) - [Usage report] Include CSV raw data files to the sent email [#4970](https://github.com/vatesfr/xen-orchestra/issues/4970) (PR [#4979](https://github.com/vatesfr/xen-orchestra/pull/4979))
- [Modal] Don't close pop-up forms when you click outside or press escape (PR [#5002](https://github.com/vatesfr/xen-orchestra/pull/5002))
### Bug fixes ### Bug fixes

2
packages/xo-web/src/common/modal.js
View File

@ -368,7 +368,9 @@ export const FormModal = decorate([
injectState, injectState,
({ state, effects }) => ( ({ state, effects }) => (
<ReactModal <ReactModal
backdrop='static'
bsSize={state.size} bsSize={state.size}
keyboard={false}
onExited={effects.reset} onExited={effects.reset}
onHide={effects.onCancel} onHide={effects.onCancel}
show={state.opened} show={state.opened}