From 2371109b6fea26c15df28caed132be2108a0d88e Mon Sep 17 00:00:00 2001 From: Mathieu <70369997+MathieuRA@users.noreply.github.com> Date: Tue, 6 Sep 2022 11:37:13 +0200 Subject: [PATCH] fix(xo-server): handle unfetched VDIs in pool.$ha_statefiles (#6404) Introduced by 4dc7575d5 Fixes zammad#9498 --- CHANGELOG.unreleased.md | 1 + packages/xo-server/src/xapi-object-to-xo.mjs | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index df126c76b..7277acc79 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -12,6 +12,7 @@ > Users must be able to say: “I had this issue, happy to know it's fixed” - [Plugin/auth-saml] Certificate input support multiline (PR [#6403](https://github.com/vatesfr/xen-orchestra/pull/6403)) +- [Storage/Pool] Fix `an error as occured` (PR [#6404](https://github.com/vatesfr/xen-orchestra/pull/6404)) ### Packages to release diff --git a/packages/xo-server/src/xapi-object-to-xo.mjs b/packages/xo-server/src/xapi-object-to-xo.mjs index 8d536d4a6..602ac298b 100644 --- a/packages/xo-server/src/xapi-object-to-xo.mjs +++ b/packages/xo-server/src/xapi-object-to-xo.mjs @@ -107,7 +107,10 @@ const TRANSFORMS = { current_operations: obj.current_operations, default_SR: link(obj, 'default_SR'), HA_enabled: Boolean(obj.ha_enabled), - haSrs: obj.$ha_statefiles.map(vdi => link(vdi, 'SR')), + + // ignore undefined VDIs, which occurs if the objects were not fetched/cached yet. + haSrs: obj.$ha_statefiles.filter(vdi => vdi !== undefined).map(vdi => link(vdi, 'SR')), + master: link(obj, 'master'), tags: obj.tags, name_description: obj.name_description,