fix(xo-server): TX checksumming is enabled by default

Introduced by fe2de9c1154c5a0b183c6d7897f1d9c376fa4031

Fixes #5234

CHANGELOG.unreleased.md

@@ -11,6 +11,8 @@
 
 > Users must be able to say: “I had this issue, happy to know it's fixed”
 
+- [VM/Network] Fix TX checksumming [#5234](https://github.com/vatesfr/xen-orchestra/issues/5234)
+
 ### Packages to release
 
 > Packages will be released in the order they are here, therefore, they should
@@ -27,3 +29,5 @@
 > - major: if the change breaks compatibility
 >
 > In case of conflict, the highest (lowest in previous list) `$version` wins.
+
+- xo-server patch

packages/xo-server/src/xapi-object-to-xo.js

@@ -658,7 +658,7 @@ const TRANSFORMS = {
       other_config: obj.other_config,
 
       // See: https://xapi-project.github.io/xen-api/networking.html
-      txChecksumming: txChecksumming === 'true' || txChecksumming === 'on',
+      txChecksumming: !(txChecksumming === 'false' || txChecksumming === 'off'),
 
       // in kB/s
       rateLimit: (() => {

packages/xo-server/src/xapi/mixins/networking.js

@@ -89,9 +89,11 @@ export default {
     },
 
     txChecksumming: {
-      // we supposed that removing `ethtool-tx` from the `other_config` will disable the functionality
       set: (value, vif) =>
-        vif.update_other_config('ethtool-tx', value ? 'true' : null),
+        vif.update_other_config(
+          'ethtool-tx',
+          value === null ? null : String(value)
+        ),
     },
   }),
 }