From 27835bfbd0c9a3400a69458c83bbac3465d14af3 Mon Sep 17 00:00:00 2001 From: badrAZ Date: Mon, 21 Jan 2019 15:10:02 +0100 Subject: [PATCH] fix(xo-web/backup-ng): smart settings not saved when editing backup (#3886) Fixes #3885 --- CHANGELOG.md | 1 + packages/xo-web/src/xo-app/backup-ng/new/index.js | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 72fffc837..f38bce041 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - [Home] Fix two tabs opened by middle click in Firefox [#3450](https://github.com/vatesfr/xen-orchestra/issues/3450) (PR [#3825](https://github.com/vatesfr/xen-orchestra/pull/3825)) - [XOA] Enable downgrade for ending trial (PR [#3867](https://github.com/vatesfr/xen-orchestra/pull/3867)) - [OVA import] allow import of big files [#3468](https://github.com/vatesfr/xen-orchestra/issues/3468) (PR [#3504](https://github.com/vatesfr/xen-orchestra/pull/3504)) +- [Backup NG] Smart settings not saved when editing a backup job [#3885](https://github.com/vatesfr/xen-orchestra/issues/3885) (PR [#3886](https://github.com/vatesfr/xen-orchestra/pull/3886)) ### Released packages diff --git a/packages/xo-web/src/xo-app/backup-ng/new/index.js b/packages/xo-web/src/xo-app/backup-ng/new/index.js index d226964cf..397c9ccc7 100644 --- a/packages/xo-web/src/xo-app/backup-ng/new/index.js +++ b/packages/xo-web/src/xo-app/backup-ng/new/index.js @@ -544,9 +544,13 @@ export default decorate([ inputTimeoutId: generateId, vmsPattern: ({ _vmsPattern }, { job }) => - defined(_vmsPattern, () => job.vms, { - type: 'VM', - }), + defined( + _vmsPattern, + () => (job.vms.id !== undefined ? undefined : job.vms), + { + type: 'VM', + } + ), needUpdateParams: (state, { job, schedules }) => job !== undefined && schedules !== undefined && !state.paramsUpdated, isJobInvalid: state =>