From 312b33ae85fdf1dc1f61a05294e06f4342e7d8be Mon Sep 17 00:00:00 2001 From: Pierre Donias Date: Mon, 4 Mar 2019 17:45:48 +0100 Subject: [PATCH] fix(xo-web/new-network): PIF should not be required (#4010) Introduced by 7a2a88b7ad93e95d890c6e2d97d131cc564fa2e3 Requiring a PIF prevented from creating private networks --- CHANGELOG.unreleased.md | 2 ++ packages/xo-web/src/xo-app/new/network/index.js | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index 642813f99..27a457ac2 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -4,6 +4,8 @@ ### Bug fixes +- [New network] PIF was wrongly required which prevented from creating a private network (PR [#4010](https://github.com/vatesfr/xen-orchestra/pull/4010)) + ### Released packages - xo-server v5.37.0 diff --git a/packages/xo-web/src/xo-app/new/network/index.js b/packages/xo-web/src/xo-app/new/network/index.js index aa3acb67b..a7e531130 100644 --- a/packages/xo-web/src/xo-app/new/network/index.js +++ b/packages/xo-web/src/xo-app/new/network/index.js @@ -92,7 +92,7 @@ const NewNetwork = decorate([ description, mtu, name, - pif: pif.id, + pif: pif == null ? undefined : pif.id, pool: pool.id, vlan, }) @@ -160,7 +160,7 @@ const NewNetwork = decorate([ multi={bonded} onChange={effects.onChangePif} predicate={pifPredicate} - required + required={bonded} value={bonded ? pifs : pif} />