From 3bad40095a7d01d9f7164f1c7cc7f34765cd2323 Mon Sep 17 00:00:00 2001 From: Julien Fontanet Date: Wed, 19 Oct 2022 18:43:48 +0200 Subject: [PATCH] fix(mixins/Config#watch): first run even when undefined Fixes issue introduced by d157fd352 --- @xen-orchestra/mixins/Config.mjs | 4 +++- CHANGELOG.unreleased.md | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/@xen-orchestra/mixins/Config.mjs b/@xen-orchestra/mixins/Config.mjs index 970fdd99f..7012dd3a8 100644 --- a/@xen-orchestra/mixins/Config.mjs +++ b/@xen-orchestra/mixins/Config.mjs @@ -58,7 +58,9 @@ export default class Config { // internal arg const processor = arguments.length > 2 ? arguments[2] : identity - let prev + // unique value to ensure first run even if the value is `undefined` + let prev = {} + const watcher = config => { try { const value = processor(niceGet(config, path)) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index d3216266d..d79caa667 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -4,12 +4,17 @@ > understandable by them. ### Enhancements + > Users must be able to say: “Nice enhancement, I'm eager to test it” + - [Backup/Encryption] Use `aes-256-gcm` instead of `aes-256-ccm` to mitigate [padding oracle attacks](https://en.wikipedia.org/wiki/Padding_oracle_attack) (PR [#6447](https://github.com/vatesfr/xen-orchestra/pull/6447)) + ### Bug fixes > Users must be able to say: “I had this issue, happy to know it's fixed” +- Really enable by default the embedded HTTP/HTTPS proxy + ### Packages to release > When modifying a package, add it here with its release type. @@ -31,6 +36,7 @@ - @vates/read-chunk patch - @xen-orchestra/fs minor - @xen-orchestra/log minor +- @xen-orchestra/mixins patch - xo-remote-parser patch - xo-server-transport-nagios patch - xo-web patch