From 3d0420dbd97db8133d89ca3c12964ae8645808f9 Mon Sep 17 00:00:00 2001
From: Julien Fontanet <julien.fontanet@isonoe.net>
Date: Mon, 14 May 2018 11:47:34 +0200
Subject: [PATCH] fix(xo-server/backupNg): clean metadata on VM iself (#2945)

---
 packages/xo-server/src/xo-mixins/backups-ng/index.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/packages/xo-server/src/xo-mixins/backups-ng/index.js b/packages/xo-server/src/xo-mixins/backups-ng/index.js
index c16154022..6b267f522 100644
--- a/packages/xo-server/src/xo-mixins/backups-ng/index.js
+++ b/packages/xo-server/src/xo-mixins/backups-ng/index.js
@@ -625,6 +625,16 @@ export default class BackupNg {
     const xapi = app.getXapi(vmUuid)
     const vm: Vm = (xapi.getObject(vmUuid): any)
 
+    // ensure the VM itself does not have any backup metadata which would be
+    // copied on manual snapshots and interfere with the backup jobs
+    if ('xo:backup:job' in vm.other_config) {
+      await xapi._updateObjectMapProperty(vm, 'other_config', {
+        'xo:backup:job': null,
+        'xo:backup:schedule': null,
+        'xo:backup:vm': null,
+      })
+    }
+
     const { id: jobId, settings } = job
     const { id: scheduleId } = schedule