NuKVM/xen-orchestra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(xo-server): use encodeURIComponent for filenames

Browse Source 
This makes sure special characters like `?` or `#` are correctly handled.
This commit is contained in:
Julien Fontanet
2019-09-10 14:39:53 +02:00
parent c44ef6a1dc
commit 4d79c462db
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/xo-server/src/api/backup-ng.js
View File

@@ -302,7 +302,7 @@ export async function fetchFiles(params) {
filename += '.zip' filename += '.zip'
return this.registerHttpRequest(handleFetchFiles, params, { return this.registerHttpRequest(handleFetchFiles, params, {
suffix: encodeURI(`/${filename}`), suffix: '/' + encodeURIComponent(filename),
}).then(url => ({ $getFrom: url })) }).then(url => ({ $getFrom: url }))
} }

2
packages/xo-server/src/api/backup.js
View File

@@ -93,7 +93,7 @@ export async function fetchFiles({ format = 'zip', ...params }) {
handleFetchFiles, handleFetchFiles,
{ ...params, format }, { ...params, format },
{ {
suffix: encodeURI(`/${fileName}`), suffix: '/' + encodeURIComponent(fileName),
} }
).then(url => ({ $getFrom: url })) ).then(url => ({ $getFrom: url }))
} }

2
packages/xo-server/src/api/vm.js
View File

@@ -1189,7 +1189,7 @@ async function export_({ vm, compress }) {
return { return {
$getFrom: await this.registerHttpRequest(handleExport, data, { $getFrom: await this.registerHttpRequest(handleExport, data, {
suffix: encodeURI(`/${vm.name_label}.xva`), suffix: '/' + encodeURIComponent(`${vm.name_label}.xva`),
}), }),
} }
} }