From 51da4a7e705c70b224bc230e96efe402dc3b96cf Mon Sep 17 00:00:00 2001 From: badrAZ Date: Tue, 20 Feb 2018 14:44:24 +0100 Subject: [PATCH] fix(xo-web/VM): show error when setting resource set fails (#2638) Fixes #2620 --- packages/xo-web/src/common/intl/messages.js | 1 + packages/xo-web/src/common/xo/index.js | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/xo-web/src/common/intl/messages.js b/packages/xo-web/src/common/intl/messages.js index 9e788944a..a5c1ba057 100644 --- a/packages/xo-web/src/common/intl/messages.js +++ b/packages/xo-web/src/common/intl/messages.js @@ -1089,6 +1089,7 @@ const messages = { importVmsCleanList: 'Reset', vmImportSuccess: 'VM import success', vmImportFailed: 'VM import failed', + setVmFailed: 'Error on setting the VM: {vm}', startVmImport: 'Import starting…', startVmExport: 'Export starting…', nCpus: 'N CPUs', diff --git a/packages/xo-web/src/common/xo/index.js b/packages/xo-web/src/common/xo/index.js index c06c87ed0..cc936bdb4 100644 --- a/packages/xo-web/src/common/xo/index.js +++ b/packages/xo-web/src/common/xo/index.js @@ -25,7 +25,7 @@ import _ from '../intl' import fetch, { post } from '../fetch' import invoke from '../invoke' import logError from '../log-error' -import renderXoItem from '../render-xo-item' +import renderXoItem, { renderXoItemFromId } from '../render-xo-item' import store from 'store' import { alert, chooseAction, confirm } from '../modal' import { error, info, success } from '../notification' @@ -1128,7 +1128,12 @@ export const revertSnapshot = vm => ) export const editVm = (vm, props) => - _call('vm.set', { ...props, id: resolveId(vm) }) + _call('vm.set', { ...props, id: resolveId(vm) }).catch(err => { + error( + _('setVmFailed', { vm: renderXoItemFromId(resolveId(vm)) }), + err.message + ) + }) export const fetchVmStats = (vm, granularity) => _call('vm.stats', { id: resolveId(vm), granularity })