fix(xen-api/_transportCall): avoid logging session ID

2019-02-22 17:47:28 +01:00 · 2019-02-22 17:47:28 +01:00 · 5eb1454e67
commit 5eb1454e67
parent 04b31db41b
1 changed files with 7 additions and 1 deletions
--- a/packages/xen-api/src/index.js
+++ b/packages/xen-api/src/index.js
@ -1145,9 +1145,15 @@ Xapi.prototype._transportCall = reduce(
            error = wrapError(error)
          }

+          // do not log the session ID
+          //
+          // TODO: should log at the session level to avoid logging sensitive
+          // values?
+          const params = args[0] === this._sessionId ? args.slice(1) : args
+
          error.call = {
            method,
-            params: replaceSensitiveValues(args, '* obfuscated *'),
+            params: replaceSensitiveValues(params, '* obfuscated *'),
          }
          throw error
        })