chore: enforce strict mode for CJS files

.eslintrc.js

@@ -1,3 +1,5 @@
+'use strict'
+
 module.exports = {
   extends: ['plugin:eslint-comments/recommended', 'standard', 'standard-jsx', 'prettier'],
   globals: {
@@ -45,5 +47,7 @@ module.exports = {
     'lines-between-class-members': 'off',
 
     'no-console': ['error', { allow: ['warn', 'error'] }],
+
+    strict: 'error',
   },
 }

@vates/coalesce-calls/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.coalesceCalls = function (fn) {
   let promise
   const clean = () => {

@vates/coalesce-calls/index.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { coalesceCalls } = require('./')

@vates/compose/index.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { compose } = require('./')

@vates/decorate-with/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.decorateWith = function decorateWith(fn, ...args) {
   return (target, name, descriptor) => ({
     ...descriptor,

@vates/disposable/debounceResource.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap } = require('@xen-orchestra/async-map')
 const { createLogger } = require('@xen-orchestra/log')
 

@vates/disposable/debounceResource.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { createDebounceResource } = require('./debounceResource')

@vates/disposable/deduped.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const ensureArray = require('ensure-array')
 const { MultiKeyMap } = require('@vates/multi-key-map')
 

@vates/disposable/deduped.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { deduped } = require('./deduped')

@vates/multi-key-map/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 class Node {
   constructor(value) {
     this.children = new Map()

@vates/multi-key-map/index.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { MultiKeyMap } = require('./')

@vates/parse-duration/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const ms = require('ms')
 
 exports.parseDuration = value => {

@vates/read-chunk/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const readChunk = (stream, size) =>
   size === 0
     ? Promise.resolve(Buffer.alloc(0))

@vates/read-chunk/index.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { Readable } = require('stream')

@vates/toggle-scripts/index.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict'
+
 const fs = require('fs')
 
 const mapKeys = (object, iteratee) => {

@xen-orchestra/async-map/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const wrapCall = (fn, arg, thisArg) => {
   try {
     return Promise.resolve(fn.call(thisArg, arg))

@xen-orchestra/async-map/index.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { asyncMapSettled } = require('./')

@xen-orchestra/async-map/legacy.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // type MaybePromise<T> = Promise<T> | T
 //
 // declare export function asyncMap<T1, T2>(

@xen-orchestra/audit-core/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/backups-cli/_composeCommands.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const getopts = require('getopts')
 
 const { version } = require('./package.json')

@xen-orchestra/backups-cli/_fs.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { dirname } = require('path')
 
 const fs = require('promise-toolbox/promisifyAll')(require('fs'))

@xen-orchestra/backups-cli/commands/clean-vms.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict'
+
 // -----------------------------------------------------------------------------
 
 const asyncMap = require('lodash/curryRight')(require('@xen-orchestra/async-map').asyncMap)

@xen-orchestra/backups-cli/commands/create-symlink-index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const filenamify = require('filenamify')
 const get = require('lodash/get')
 const { asyncMap } = require('@xen-orchestra/async-map')

@xen-orchestra/backups-cli/commands/info.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const groupBy = require('lodash/groupBy')
 const { asyncMap } = require('@xen-orchestra/async-map')
 const { createHash } = require('crypto')

@xen-orchestra/backups-cli/index.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict'
+
 require('./_composeCommands')({
   'clean-vms': {
     get main() {

@xen-orchestra/backups/Backup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap, asyncMapSettled } = require('@xen-orchestra/async-map')
 const Disposable = require('promise-toolbox/Disposable')
 const ignoreErrors = require('promise-toolbox/ignoreErrors')

@xen-orchestra/backups/DurablePartition.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap } = require('@xen-orchestra/async-map')
 
 exports.DurablePartition = class DurablePartition {

@xen-orchestra/backups/ImportVmBackup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const assert = require('assert')
 
 const { formatFilenameDate } = require('./_filenameDate.js')

@xen-orchestra/backups/RemoteAdapter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap, asyncMapSettled } = require('@xen-orchestra/async-map')
 const Disposable = require('promise-toolbox/Disposable')
 const fromCallback = require('promise-toolbox/fromCallback')

@xen-orchestra/backups/RestoreMetadataBackup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { DIR_XO_POOL_METADATA_BACKUPS } = require('./RemoteAdapter.js')
 const { PATH_DB_DUMP } = require('./_PoolMetadataBackup.js')
 

@xen-orchestra/backups/Task.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const CancelToken = require('promise-toolbox/CancelToken')
 const Zone = require('node-zone')
 

@xen-orchestra/backups/_PoolMetadataBackup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap } = require('@xen-orchestra/async-map')
 
 const { DIR_XO_POOL_METADATA_BACKUPS } = require('./RemoteAdapter.js')

@xen-orchestra/backups/_VmBackup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const assert = require('assert')
 const findLast = require('lodash/findLast.js')
 const groupBy = require('lodash/groupBy.js')

@xen-orchestra/backups/_XoMetadataBackup.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap } = require('@xen-orchestra/async-map')
 
 const { DIR_XO_CONFIG_BACKUPS } = require('./RemoteAdapter.js')

@xen-orchestra/backups/_backupType.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.isMetadataFile = filename => filename.endsWith('.json')
 exports.isVhdFile = filename => filename.endsWith('.vhd')
 exports.isXvaFile = filename => filename.endsWith('.xva')

@xen-orchestra/backups/_backupWorker.js

@@ -1,3 +1,5 @@
+'use strict'
+
 require('@xen-orchestra/log/configure.js').catchGlobalErrors(
   require('@xen-orchestra/log').createLogger('xo:backups:worker')
 )

@xen-orchestra/backups/_cancelableMap.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const cancelable = require('promise-toolbox/cancelable')
 const CancelToken = require('promise-toolbox/CancelToken')
 

@xen-orchestra/backups/_cleanVm.integ.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const rimraf = require('rimraf')

@xen-orchestra/backups/_cleanVm.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const assert = require('assert')
 const sum = require('lodash/sum')
 const { asyncMap } = require('@xen-orchestra/async-map')

@xen-orchestra/backups/_deltaVm.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const compareVersions = require('compare-versions')
 const find = require('lodash/find.js')
 const groupBy = require('lodash/groupBy.js')

@xen-orchestra/backups/_extractIdsFromSimplePattern.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.extractIdsFromSimplePattern = function extractIdsFromSimplePattern(pattern) {
   if (pattern === undefined) {
     return []

@xen-orchestra/backups/_filenameDate.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { utcFormat, utcParse } = require('d3-time-format')
 
 // Format a date in ISO 8601 in a safe way to be used in filenames

@xen-orchestra/backups/_forkStreamUnpipe.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const eos = require('end-of-stream')
 const { PassThrough } = require('stream')
 

@xen-orchestra/backups/_getOldEntries.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // returns all entries but the last retention-th
 exports.getOldEntries = function getOldEntries(retention, entries) {
   return entries === undefined ? [] : retention > 0 ? entries.slice(0, -retention) : entries

@xen-orchestra/backups/_getTmpDir.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const Disposable = require('promise-toolbox/Disposable')
 const { join } = require('path')
 const { mkdir, rmdir } = require('fs-extra')

@xen-orchestra/backups/_getVmBackupDir.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const BACKUP_DIR = 'xo-vm-backups'
 exports.BACKUP_DIR = BACKUP_DIR
 

@xen-orchestra/backups/_isValidXva.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const assert = require('assert')
 
 const COMPRESSED_MAGIC_NUMBERS = [

@xen-orchestra/backups/_listPartitions.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fromCallback = require('promise-toolbox/fromCallback')
 const { createLogger } = require('@xen-orchestra/log')
 const { createParser } = require('parse-pairs')

@xen-orchestra/backups/_lvm.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fromCallback = require('promise-toolbox/fromCallback')
 const { createParser } = require('parse-pairs')
 const { execFile } = require('child_process')

@xen-orchestra/backups/_watchStreamSize.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.watchStreamSize = function watchStreamSize(stream, container = { size: 0 }) {
   stream.on('data', data => {
     container.size += data.length

@xen-orchestra/backups/formatVmBackups.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const mapValues = require('lodash/mapValues.js')
 const { dirname } = require('path')
 

@xen-orchestra/backups/merge-worker/cli.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict'
+
 const { catchGlobalErrors } = require('@xen-orchestra/log/configure.js')
 const { createLogger } = require('@xen-orchestra/log')
 const { getSyncedHandler } = require('@xen-orchestra/fs')

@xen-orchestra/backups/merge-worker/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { join, resolve } = require('path')
 const { spawn } = require('child_process')
 const { check } = require('proper-lockfile')

@xen-orchestra/backups/parseMetadataBackupId.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { DIR_XO_CONFIG_BACKUPS, DIR_XO_POOL_METADATA_BACKUPS } = require('./RemoteAdapter.js')
 
 exports.parseMetadataBackupId = function parseMetadataBackupId(backupId) {

@xen-orchestra/backups/runBackupWorker.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const path = require('path')
 const { createLogger } = require('@xen-orchestra/log')
 const { fork } = require('child_process')

@xen-orchestra/backups/tests.fixtures.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // a valid footer of a 2
 exports.VHDFOOTER = {
   cookie: 'conectix',

@xen-orchestra/backups/writers/DeltaBackupWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const assert = require('assert')
 const map = require('lodash/map.js')
 const mapValues = require('lodash/mapValues.js')

@xen-orchestra/backups/writers/DeltaReplicationWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { asyncMap, asyncMapSettled } = require('@xen-orchestra/async-map')
 const ignoreErrors = require('promise-toolbox/ignoreErrors')
 const { formatDateTime } = require('@xen-orchestra/xapi')

@xen-orchestra/backups/writers/FullBackupWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { formatFilenameDate } = require('../_filenameDate.js')
 const { getOldEntries } = require('../_getOldEntries.js')
 const { getVmBackupDir } = require('../_getVmBackupDir.js')

@xen-orchestra/backups/writers/FullReplicationWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const ignoreErrors = require('promise-toolbox/ignoreErrors')
 const { asyncMap, asyncMapSettled } = require('@xen-orchestra/async-map')
 const { formatDateTime } = require('@xen-orchestra/xapi')

@xen-orchestra/backups/writers/_AbstractDeltaWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { AbstractWriter } = require('./_AbstractWriter.js')
 
 exports.AbstractDeltaWriter = class AbstractDeltaWriter extends AbstractWriter {

@xen-orchestra/backups/writers/_AbstractFullWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { AbstractWriter } = require('./_AbstractWriter.js')
 
 exports.AbstractFullWriter = class AbstractFullWriter extends AbstractWriter {

@xen-orchestra/backups/writers/_AbstractWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.AbstractWriter = class AbstractWriter {
   constructor({ backup, settings }) {
     this._backup = backup

@xen-orchestra/backups/writers/_MixinBackupWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { createLogger } = require('@xen-orchestra/log')
 const { join } = require('path')
 

@xen-orchestra/backups/writers/_MixinReplicationWriter.js

@@ -1,3 +1,5 @@
+'use strict'
+
 exports.MixinReplicationWriter = (BaseClass = Object) =>
   class MixinReplicationWriter extends BaseClass {
     constructor({ sr, ...rest }) {

@xen-orchestra/backups/writers/_checkVhd.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const openVhd = require('vhd-lib').openVhd
 const Disposable = require('promise-toolbox/Disposable')
 

@xen-orchestra/backups/writers/_listReplicatedVms.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const getReplicatedVmDatetime = vm => {
   const { 'xo:backup:datetime': datetime = vm.name_label.slice(-17, -1) } = vm.other_config
   return datetime

@xen-orchestra/backups/writers/_packUuid.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const PARSE_UUID_RE = /-/g
 
 exports.packUuid = function packUuid(uuid) {

@xen-orchestra/cr-seed-cli/index.js

@@ -1,5 +1,7 @@
 #!/usr/bin/env node
 
+'use strict'
+
 const { Ref, Xapi } = require('xen-api')
 const { defer } = require('golike-defer')
 

@xen-orchestra/cron/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/defined/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 // Usage:
 //
 // ```js

@xen-orchestra/emit-async/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 module.exports = function emitAsync(event) {
   let opts
   let i = 1

@xen-orchestra/fs/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/log/configure.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const createConsoleTransport = require('./transports/console')
 const { LEVELS, resolve } = require('./levels')
 const { compileGlobPattern } = require('./utils')

@xen-orchestra/log/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const createTransport = require('./transports/console')
 const { LEVELS, resolve } = require('./levels')
 

@xen-orchestra/log/levels.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const LEVELS = Object.create(null)
 exports.LEVELS = LEVELS
 

@xen-orchestra/log/levels.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { forEach, isInteger } = require('lodash')

@xen-orchestra/log/transports/console.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { LEVELS, NAMES } = require('../levels')
 
 const { DEBUG, ERROR, FATAL, INFO, WARN } = LEVELS

@xen-orchestra/log/transports/email.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fromCallback = require('promise-toolbox/fromCallback')
 const nodemailer = require('nodemailer') // eslint-disable-line n/no-extraneous-import
 const prettyFormat = require('pretty-format') // eslint-disable-line n/no-extraneous-import

@xen-orchestra/log/transports/memory.js

@@ -1,3 +1,5 @@
+'use strict'
+
 function createTransport() {
   const memoryLogger = log => {
     logs.push(log)

@xen-orchestra/log/transports/syslog.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const fromCallback = require('promise-toolbox/fromCallback')
 const splitHost = require('split-host')
 const { createClient, Facility, Severity, Transport } = require('syslog-client')

@xen-orchestra/log/utils.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const escapeRegExp = require('lodash/escapeRegExp')
 
 // ===================================================================

@xen-orchestra/log/utils.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const { compileGlobPattern } = require('./utils')

@xen-orchestra/mixin/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const camelCase = require('lodash/camelCase')
 
 const { defineProperties, defineProperty, keys } = Object

@xen-orchestra/mixin/legacy.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { getBoundPropertyDescriptor } = require('bind-property-descriptor')
 
 // ===================================================================

@xen-orchestra/mixins/Config.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const get = require('lodash/get')
 const identity = require('lodash/identity')
 const isEqual = require('lodash/isEqual')

@xen-orchestra/mixins/Hooks.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const assert = require('assert')
 const emitAsync = require('@xen-orchestra/emit-async')
 const EventEmitter = require('events')

@xen-orchestra/openflow/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/openflow/parse-socket.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('./dist/parse-socket')

@xen-orchestra/proxy-cli/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/self-signed/index.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const { execFile } = require('child_process')
 
 const openssl = (cmd, args, { input, ...opts } = {}) =>

@xen-orchestra/template/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/upload-ova/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

@xen-orchestra/upload-ova/src/config.js

@@ -1,7 +1,3 @@
-'use strict'
-
-// ===================================================================
-
 import assign from 'lodash/assign'
 import get_ from 'lodash/get'
 import unset_ from 'lodash/unset'

@xen-orchestra/xapi/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

packages/complex-matcher/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

packages/value-matcher/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

packages/vhd-cli/.babelrc.js

@@ -1 +1,3 @@
+'use strict'
+
 module.exports = require('../../@xen-orchestra/babel-config')(require('./package.json'))

packages/vhd-lib/Vhd/VhdAbstract.integ.spec.js

@@ -1,3 +1,5 @@
+'use strict'
+
 /* eslint-env jest */
 
 const rimraf = require('rimraf')

packages/vhd-lib/Vhd/VhdAbstract.js

@@ -1,3 +1,5 @@
+'use strict'
+
 const {
   computeBatSize,
   computeFullBlockSize,