From 76357fb918d247c9a45c95ae0cf39329b5af6df9 Mon Sep 17 00:00:00 2001
From: Julien Fontanet <julien.fontanet@isonoe.net>
Date: Mon, 31 Jul 2017 14:35:31 +0200
Subject: [PATCH] fix(CollectionRedis): do not fail when entry does not exist
 (#590)

---
 src/collection/redis.js | 33 ++++++++++++++++-----------------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/src/collection/redis.js b/src/collection/redis.js
index 67ce524b7..3dca903ca 100644
--- a/src/collection/redis.js
+++ b/src/collection/redis.js
@@ -95,24 +95,23 @@ export default class Redis extends Collection {
       }
       const { id } = model
 
-      const success = await redis.sadd(prefix + '_ids', id)
+      const newEntry = await redis.sadd(prefix + '_ids', id)
 
-      // The entry already exists an we are not in replace mode.
-      if (!success && !replace) {
-        throw new ModelAlreadyExists(id)
-      }
+      if (!newEntry) {
+        if (!replace) {
+          throw new ModelAlreadyExists(id)
+        }
 
-      // TODO: Remove existing fields.
-
-      // remove the previous values from indexes
-      if (replace && indexes.length !== 0) {
-        const previous = await redis.hgetall(`${prefix}:${id}`)
-        await asyncMap(indexes, index => {
-          const value = previous[index]
-          if (value !== undefined) {
-            return redis.srem(`${prefix}_${index}:${value}`, id)
-          }
-        })
+        // remove the previous values from indexes
+        if (indexes.length !== 0) {
+          const previous = await redis.hgetall(`${prefix}:${id}`)
+          await asyncMap(indexes, index => {
+            const value = previous[index]
+            if (value !== undefined) {
+              return redis.srem(`${prefix}_${index}:${value}`, id)
+            }
+          })
+        }
       }
 
       const params = []
@@ -192,7 +191,7 @@ export default class Redis extends Collection {
     if (indexes.length !== 0) {
       promise = Promise.all([ promise, asyncMap(ids, id =>
         redis.hgetall(`${prefix}:${id}`).then(values =>
-          asyncMap(indexes, index => {
+          values != null && asyncMap(indexes, index => {
             const value = values[index]
             if (value !== undefined) {
               return redis.srem(`${prefix}_${index}:${value}`, id)