feat(xo-web/vm/networks): improve tooltip messages (#5227)

See https://github.com/vatesfr/xen-orchestra/issues/4713#issuecomment-667655321

CHANGELOG.unreleased.md

@@ -7,6 +7,8 @@
 
 > Users must be able to say: “Nice enhancement, I'm eager to test it”
 
+- [VM/network] VIF's locking mode: improve tooltip messages [#4713](https://github.com/vatesfr/xen-orchestra/issues/4713) (PR [#5227](https://github.com/vatesfr/xen-orchestra/pull/5227))
+
 ### Bug fixes
 
 > Users must be able to say: “I had this issue, happy to know it's fixed”
@@ -27,3 +29,5 @@
 > - major: if the change breaks compatibility
 >
 > In case of conflict, the highest (lowest in previous list) `$version` wins.
+
+- xo-web minor

packages/xo-web/src/common/intl/messages.js

@@ -1156,13 +1156,15 @@ const messages = {
   vifMacAutoGenerate: 'Auto-generated if empty',
   vifAllowedIps: 'Allowed IPs',
   vifNoIps: 'No IPs',
-  vifDisabledNetwork: 'Network disabled',
-  vifLockedNetwork: 'Network locked',
+  vifLockingModeDisabled: 'VIF locking mode is disabled',
+  vifLockingModeUnlocked: 'VIF locking mode is unlocked',
+  vifLockingModeLocked: 'VIF locking mode is locked',
+  networkDefaultLockingModeDisabled: 'Network default locking mode is disabled',
+  networkDefaultLockingModeUnlocked: 'Network default locking mode is unlocked',
   vifLockedNetworkNoIps:
     'Network locked and no IPs are allowed for this interface',
   vifUnlockedNetworkWithIps:
-    'Network not locked: some IPs are unnecessarily set as allowed for this interface',
-  vifUnLockedNetwork: 'Network not locked',
+    'Some IPs are unnecessarily set as allowed for this interface',
   vifUnknownNetwork: 'Unknown network',
   vifCreate: 'Create',
 

packages/xo-web/src/xo-app/vm/tab-network.js

@@ -293,7 +293,7 @@ class VifStatus extends BaseComponent {
 
     if (lockingMode === 'disabled') {
       return (
-        <Tooltip content={_('vifDisabledNetwork')}>
+        <Tooltip content={_('vifLockingModeDisabled')}>
           <Icon icon='vif-disable' />
         </Tooltip>
       )
@@ -301,7 +301,7 @@ class VifStatus extends BaseComponent {
 
     if (lockingMode === 'unlocked') {
       return (
-        <Tooltip content={_('vifUnLockedNetwork')}>
+        <Tooltip content={_('vifLockingModeUnlocked')}>
           <Icon icon='unlock' />
         </Tooltip>
       )
@@ -309,7 +309,7 @@ class VifStatus extends BaseComponent {
 
     if (lockingMode === 'locked') {
       return (
-        <Tooltip content={_('vifLockedNetwork')}>
+        <Tooltip content={_('vifLockingModeLocked')}>
           <Icon icon='lock' />
         </Tooltip>
       )
@@ -325,7 +325,7 @@ class VifStatus extends BaseComponent {
     }
     if (network.defaultIsLocked) {
       return (
-        <Tooltip content={_('vifLockedNetwork')}>
+        <Tooltip content={_('networkDefaultLockingModeDisabled')}>
           <StackedIcons
             icons={[
               { icon: 'vif-disable', size: 1 },
@@ -336,7 +336,7 @@ class VifStatus extends BaseComponent {
       )
     }
     return (
-      <Tooltip content={_('vifUnLockedNetwork')}>
+      <Tooltip content={_('networkDefaultLockingModeUnlocked')}>
         <StackedIcons
           icons={[
             { icon: 'unlock', size: 1 },