chore: String#substring() → String#slice()

- homogeneity
- [faster in v8](https://bugs.chromium.org/p/v8/issues/detail?id=6730)

packages/xo-server/src/api/xosan.js

@@ -351,7 +351,7 @@ async function remoteSsh(glusterEndpoint, cmd, ignoreError = false) {
     log.debug(`result of ${result.command.join(' ')}`, {
       exit: result.exit,
       err: result.stderr,
-      out: result.stdout.substring(0, 1000),
+      out: result.stdout.slice(0, 1000),
     })
     // 255 seems to be ssh's own error codes.
     if (result.exit !== 255) {

packages/xo-web/src/xo-app/home/host-item.js

@@ -41,7 +41,7 @@ import styles from './index.css'
   ),
 }))
 export default class HostItem extends Component {
-  get _isRunning () {
+  get _isRunning() {
     const host = this.props.item
     return host && host.power_state === 'Running'
   }
@@ -58,7 +58,7 @@ export default class HostItem extends Component {
   _toggleExpanded = () => this.setState({ expanded: !this.state.expanded })
   _onSelect = () => this.props.onSelect(this.props.item.id)
 
-  render () {
+  render() {
     const { item: host, container, expandAll, selected, nVms } = this.props
     const toolTipContent =
       host.power_state === `Running` && !host.enabled
@@ -228,7 +228,7 @@ export default class HostItem extends Component {
               <span>
                 {host.cpus.cores}x <Icon icon='cpu' /> &nbsp;{' '}
                 {formatSizeShort(host.memory.size)} <Icon icon='memory' />{' '}
-                &nbsp; v{host.version.substring(0, 3)}
+                &nbsp; v{host.version.slice(0, 3)}
               </span>
             </Col>
             <Col mediumSize={4}>

packages/xo-web/src/xo-app/new-vm/index.js

@@ -138,7 +138,7 @@ class Vif extends BaseComponent {
     vif => ipPool => includes(ipPool.networks, vif.network)
   )
 
-  render () {
+  render() {
     const {
       intl: { formatMessage },
       ipPoolsConfigured,
@@ -220,7 +220,10 @@ class Vif extends BaseComponent {
   user: subscribeCurrentUser,
 })
 @connectStore(() => ({
-  isAdmin: createSelector(getUser, user => user && user.permission === 'admin'),
+  isAdmin: createSelector(
+    getUser,
+    user => user && user.permission === 'admin'
+  ),
   isPoolAdmin: getIsPoolAdmin,
   networks: createGetObjectsOfType('network').sort(),
   pool: createGetObject((_, props) => props.location.query.pool),
@@ -241,7 +244,7 @@ export default class NewVm extends BaseComponent {
     router: PropTypes.object,
   }
 
-  constructor () {
+  constructor() {
     super()
 
     this._uniqueId = 0
@@ -250,7 +253,7 @@ export default class NewVm extends BaseComponent {
     this.state = { state: {} }
   }
 
-  componentDidMount () {
+  componentDidMount() {
     this._reset()
   }
 
@@ -271,7 +274,7 @@ export default class NewVm extends BaseComponent {
 
   // Utils -----------------------------------------------------------------------
 
-  get _isDiskTemplate () {
+  get _isDiskTemplate() {
     const { template } = this.state.state
     return (
       template &&
@@ -804,9 +807,7 @@ export default class NewVm extends BaseComponent {
     const { userSshKeys } = this.props
     const splitKey = newSshKey.split(' ')
     const title =
-      splitKey.length === 3
-        ? splitKey[2].split('\n')[0]
-        : newSshKey.substring(newSshKey.length - 10, newSshKey.length)
+      splitKey.length === 3 ? splitKey[2].split('\n')[0] : newSshKey.slice(-10)
 
     // save key
     addSshKey({
@@ -861,7 +862,7 @@ export default class NewVm extends BaseComponent {
     )
   }
 
-  render () {
+  render() {
     const { pool } = this.props
     return (
       <Page header={this._renderHeader()}>

packages/xo-web/src/xo-app/vm-import/index.js

@@ -83,7 +83,7 @@ class VmData extends Component {
     pool: PropTypes.object.isRequired,
   }
 
-  get value () {
+  get value() {
     const { props, refs } = this
     return {
       descriptionLabel: refs.descriptionLabel.value,
@@ -110,7 +110,7 @@ class VmData extends Component {
     id => network => network.$pool === id
   )
 
-  render () {
+  render() {
     const {
       descriptionLabel,
       defaultNetwork,
@@ -241,7 +241,7 @@ const getRedirectionUrl = vms =>
     : `/home?s=${encodeURIComponent(`id:|(${vms.join(' ')})`)}&t=VM`
 
 export default class Import extends Component {
-  constructor (props) {
+  constructor(props) {
     super(props)
     this.state.vms = []
   }
@@ -273,7 +273,7 @@ export default class Import extends Component {
 
         if (
           extIndex >= 0 &&
-          (type = name.substring(extIndex + 1)) &&
+          (type = name.slice(extIndex + 1)) &&
           (func = FORMAT_TO_HANDLER[type])
         ) {
           push(parseFile(file, type, func))
@@ -314,7 +314,7 @@ export default class Import extends Component {
     })
   }
 
-  render () {
+  render() {
     const { pool, sr, srPredicate, vms } = this.state
 
     return (