diff --git a/src/backupNg/__snapshots__/backupNg.spec.js.snap b/src/backupNg/__snapshots__/backupNg.spec.js.snap index 8d5f11b55..1a7db8f20 100644 --- a/src/backupNg/__snapshots__/backupNg.spec.js.snap +++ b/src/backupNg/__snapshots__/backupNg.spec.js.snap @@ -95,43 +95,6 @@ Array [ exports[`backupNg .runJob() : fails trying to run a backup job without schedule 1`] = `[JsonRpcError: invalid parameters]`; -exports[`backupNg .runJob() : fails trying to run backup job with srs without copyRetention 1`] = ` -Object { - "data": Object { - "mode": "full", - "reportWhen": "never", - }, - "end": Any, - "id": Any, - "jobId": Any, - "jobName": "default-backupNg", - "message": "backup", - "scheduleId": Any, - "start": Any, - "status": "failure", -} -`; - -exports[`backupNg .runJob() : fails trying to run backup job with srs without copyRetention 2`] = ` -Object { - "data": Object { - "id": Any, - "type": "VM", - }, - "end": Any, - "id": Any, - "message": Any, - "result": Object { - "message": "copy, export and snapshot retentions cannot both be 0", - "name": "Error", - "stack": Any, - }, - "start": Any, - "status": "failure", -} -`; - - exports[`backupNg .runJob() : fails trying to run backup job with remotes without exportRetention 1`] = ` Object { "data": Object { diff --git a/src/backupNg/backupNg.spec.js b/src/backupNg/backupNg.spec.js index 1c1ba6467..e5510f171 100644 --- a/src/backupNg/backupNg.spec.js +++ b/src/backupNg/backupNg.spec.js @@ -276,59 +276,6 @@ describe("backupNg", () => { }); expect(task.data.id).toBe(config.vmIdXoTest); }); - - it("fails trying to run backup job with srs without copyRetention", async () => { - const scheduleTempId = randomId(); - const { id: jobId } = await xo.createTempBackupNgJob({ - ...defaultBackupNg, - schedules: { - [scheduleTempId]: DEFAULT_SCHEDULE, - }, - settings: { - ...defaultBackupNg.settings, - [scheduleTempId]: {}, - }, - srs: { - id: config.srs.defaultSr, - }, - }); - - const schedule = await xo.getSchedule({ jobId }); - expect(typeof schedule).toBe("object"); - await xo.call("backupNg.runJob", { id: jobId, schedule: schedule.id }); - - const [ - { - tasks: [task], - ...log - }, - ] = await xo.call("backupNg.getLogs", { - jobId, - scheduleId: schedule.id, - }); - - expect(log).toMatchSnapshot({ - end: expect.any(Number), - id: expect.any(String), - jobId: expect.any(String), - scheduleId: expect.any(String), - start: expect.any(Number), - }); - - expect(task).toMatchSnapshot({ - data: { - id: expect.any(String), - }, - end: expect.any(Number), - id: expect.any(String), - message: expect.any(String), - result: { - stack: expect.any(String), - }, - start: expect.any(Number), - }); - expect(task.data.id).toBe(config.vmIdXoTest); - }); }); test("execute three times a rolling snapshot with 2 as retention & revert to an old state", async () => {