feat(xo-server-audit/_uploadLastHash): check integrity sequentially (#5250)

- implementation is simpler
- stop on first error

CHANGELOG.unreleased.md

@@ -35,5 +35,6 @@
 >
 > In case of conflict, the highest (lowest in previous list) `$version` wins.
 
+- xo-server-audit patch
 - xo-vmdk-to-vhd patch
 - xo-web minor

packages/xo-server-audit/src/index.js

@@ -335,16 +335,18 @@ class AuditXoPlugin {
       }
 
       // check the integrity of all stored hashes
-      integrityCheckSuccess = await Promise.all(
+      try {
-        hashes.map((oldest, key) =>
+        for (let i = 0; i < hashes.length - 1; ++i) {
-          oldest !== lastHash
+          await this._checkIntegrity({
-            ? this._checkIntegrity({ oldest, newest: hashes[key + 1] })
+            oldest: hashes[i],
-            : true
+            newest: hashes[i + 1],
-        )
+          })
-      ).then(
+        }
-        () => true,
+
-        () => false
+        integrityCheckSuccess = true
-      )
+      } catch (_) {
+        integrityCheckSuccess = false
+      }
     }
 
     // generate a valid fingerprint of all stored records in case of a failure integrity check