From 8e7e1fccbee4f846cee95d74ceb71dfe0d6970c4 Mon Sep 17 00:00:00 2001 From: Julien Fontanet Date: Tue, 14 Aug 2018 14:18:42 +0200 Subject: [PATCH] chore(xo-server/Model): remove unused validate() --- packages/xo-server/src/collection.js | 20 +------------------- packages/xo-server/src/model.js | 5 ----- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/packages/xo-server/src/collection.js b/packages/xo-server/src/collection.js index 79748d163..036db14d8 100644 --- a/packages/xo-server/src/collection.js +++ b/packages/xo-server/src/collection.js @@ -38,19 +38,7 @@ export default class Collection extends EventEmitter { const { Model } = this map( models, - model => { - if (!(model instanceof Model)) { - model = new Model(model) - } - - const error = model.validate() - if (error) { - // TODO: Better system inspired by Backbone.js - throw error - } - - return model.properties - }, + model => (model instanceof Model ? model.properties : model), models ) @@ -112,12 +100,6 @@ export default class Collection extends EventEmitter { throw new Error('a model without an id cannot be updated') } - const error = model.validate() - if (error !== undefined) { - // TODO: Better system inspired by Backbone.js. - throw error - } - return model.properties }, models diff --git a/packages/xo-server/src/model.js b/packages/xo-server/src/model.js index 94c46fe69..1e40a5b73 100644 --- a/packages/xo-server/src/model.js +++ b/packages/xo-server/src/model.js @@ -15,11 +15,6 @@ export default class Model extends EventEmitter { } } - // Validate the defined properties. - // - // Returns the error if any. - validate (properties) {} - // Get a property. get (name, def) { const value = this.properties[name]