NuKVM/xen-orchestra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(xen-api#unsetField): replaced by setField(_, null)

Browse Source
This commit is contained in:
Julien Fontanet 2019-02-22 19:46:49 +01:00
parent 705d069246
commit 8e8b1c009a
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/xen-api/src/index.js
View File

@ -737,15 +737,16 @@ export class Xapi extends EventEmitter {
getKeys(entries).map(entry => { getKeys(entries).map(entry => {
const value = entries[entry] const value = entries[entry]
if (value !== undefined) { if (value !== undefined) {
return value === null return this.setFieldEntry(type, ref, field, entry, value)
? this.unsetFieldEntry(type, ref, field, entry)
: this.setFieldEntry(type, ref, field, entry, value)
} }
}) })
).then(noop) ).then(noop)
} }
async setFieldEntry(type, ref, field, entry, value) { async setFieldEntry(type, ref, field, entry, value) {
if (value === null) {
return this.call(`${type}.remove_from_${field}`, ref, entry)
}
while (true) { while (true) {
try { try {
await this.call(`${type}.add_to_${field}`, ref, entry, value) await this.call(`${type}.add_to_${field}`, ref, entry, value)
@ -755,14 +756,10 @@ export class Xapi extends EventEmitter {
throw error throw error
} }
} }
await this.unsetFieldEntry(type, ref, field, entry) await this.call(`${type}.remove_from_${field}`, ref, entry)
} }
} }
unsetFieldEntry(type, ref, field, entry) {
return this.call(`${type}.remove_from_${field}`, ref, entry)
}
watchTask(ref) { watchTask(ref) {
const watchers = this._taskWatchers const watchers = this._taskWatchers
if (watchers === undefined) { if (watchers === undefined) {