From 90ea2284c6e7ec0512f437e2772f4254676cb685 Mon Sep 17 00:00:00 2001 From: Florent BEAUCHAMP Date: Mon, 7 Nov 2022 13:28:43 +0100 Subject: [PATCH] fix(xo-vmk-to-vhd): failing tests (#6518) Sometimes `buffer.allocUnsafe` was generating an buffer containing only zeroes, that buffer was filtered in packages/xo-vmdk-to-vhd/src/vmdk-generate.js line 140, thus the generated vmdk was variable --- packages/xo-vmdk-to-vhd/src/vmdk-to-vhd.integ.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/xo-vmdk-to-vhd/src/vmdk-to-vhd.integ.spec.js b/packages/xo-vmdk-to-vhd/src/vmdk-to-vhd.integ.spec.js index 3cb2c711e..290a16b70 100644 --- a/packages/xo-vmdk-to-vhd/src/vmdk-to-vhd.integ.spec.js +++ b/packages/xo-vmdk-to-vhd/src/vmdk-to-vhd.integ.spec.js @@ -94,8 +94,8 @@ test('Can generate an empty VMDK file', async () => { test('Can generate a small VMDK file', async () => { const defaultVhdToVmdkRatio = 16 const blockSize = 1024 * 1024 - const b1 = Buffer.allocUnsafe(blockSize) - const b2 = Buffer.allocUnsafe(blockSize) + const b1 = Buffer.alloc(blockSize, 255) + const b2 = Buffer.alloc(blockSize, 255) const blockGenerator = [ { lba: 0, block: b1 }, { lba: blockSize, block: b2 },