NuKVM/xen-orchestra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Various fixes and enhancements

Browse Source
This commit is contained in:
Fabrice Marsaud 2015-03-31 17:08:41 +02:00
parent 265d77d776
commit 92d7d61926
1 changed files with 27 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
packages/xo-collection/collection.js
View File

@ -26,39 +26,33 @@ class Collection {
} }
bufferChanges (state = true) { bufferChanges () {
if (state && this._buffer) { if (this._buffer) {
throw new AlreadyBuffering('Already buffering'); // FIXME Really ?... throw new AlreadyBuffering('Already buffering'); // FIXME Really ?...
} }
if (!state && !this._buffer) {
throw new NotBuffering('Not buffering'); // FIXME Really ?...
}
this._buffer = state;
if (!this._buffer) { this._buffer = true;
return () => {
if (!this._buffer) {
throw new NotBuffering('Nothing to flush'); // FIXME Really ?
}
this._buffering = false; // FIXME Really ?
// TODO Emits events for buffered changes
this._initBuffer(); this._initBuffer();
}
} };
flush () {
if (!this._buffer) {
throw new NotBuffering('NothingToFlush');
}
this._buffering = false; // FIXME Really ?
// TODO Throws buffered events
this._initBuffer();
} }
_touch (key, action) { _touch (key, action) {
// TODO Buffers changes or throws an event // TODO Buffers changes or emits an event
} }
@ -75,15 +69,18 @@ class Collection {
delete this._map[key]; delete this._map[key];
this._touch(key, 'remove'); this._touch(key, 'remove');
return this; return this;
} }
getId (item) { getId (item) {
return item.id; return item.id;
} }
has (key) { has (key) {
return this._map.hasOwnProperty(key); return Object.hasOwnProperty.call(this._map, key);
} }
@ -106,6 +103,7 @@ class Collection {
} }
return [key, value]; return [key, value];
} }
_assertHas(key) { _assertHas(key) {
@ -116,7 +114,7 @@ class Collection {
} }
_assertNotHas(key) { _assertHasNot(key) {
if (this.has(key)) { if (this.has(key)) {
throw new DuplicateEntry(); throw new DuplicateEntry();
@ -128,7 +126,7 @@ class Collection {
const [key, value] = this.resolveEntry.apply(this, arguments); const [key, value] = this.resolveEntry.apply(this, arguments);
this._assertNotHas(key); this._assertHasNot(key);
this._size++; this._size++;
return this._set(key, value); return this._set(key, value);
@ -176,11 +174,15 @@ class Collection {
} }
get size () { get size () {
return this._size; return this._size;
} }
get all () { get all () {
return this._map; return this._map;
} }
} }