chore(xo-server/plugin-metadata): use builtin (un)serialize

packages/xo-server/src/models/plugin-metadata.mjs

@@ -1,18 +1,26 @@
 import Collection from '../collection/redis.mjs'
 import { createLogger } from '@xen-orchestra/log'
-import { forEach } from '../utils.mjs'
 
 const log = createLogger('xo:plugin-metadata')
 
 // ===================================================================
 
 export class PluginsMetadata extends Collection {
-  async save({ id, autoload, configuration }) {
+  _serialize(metadata) {
-    return /* await */ this.update({
+    const { autoload, configuration } = metadata
-      id,
+    metadata.autoload = JSON.stringify(autoload)
-      autoload: autoload ? 'true' : 'false',
+    metadata.configuration = JSON.stringify(configuration)
-      configuration: configuration && JSON.stringify(configuration),
+  }
-    })
+
+  _unserialize(metadata) {
+    const { autoload, configuration } = metadata
+    metadata.autoload = autoload === 'true'
+    try {
+      metadata.configuration = configuration && JSON.parse(configuration)
+    } catch (error) {
+      log.warn(`cannot parse pluginMetadata.configuration: ${configuration}`)
+      metadata.configuration = []
+    }
   }
 
   async merge(id, data) {
@@ -21,27 +29,9 @@ export class PluginsMetadata extends Collection {
       throw new Error('no such plugin metadata')
     }
 
-    return /* await */ this.save({
+    return /* await */ this.update({
       ...pluginMetadata,
       ...data,
     })
   }
-
-  async get(properties) {
-    const pluginsMetadata = await super.get(properties)
-
-    // Deserializes.
-    forEach(pluginsMetadata, pluginMetadata => {
-      const { autoload, configuration } = pluginMetadata
-      pluginMetadata.autoload = autoload === 'true'
-      try {
-        pluginMetadata.configuration = configuration && JSON.parse(configuration)
-      } catch (error) {
-        log.warn(`cannot parse pluginMetadata.configuration: ${configuration}`)
-        pluginMetadata.configuration = []
-      }
-    })
-
-    return pluginsMetadata
-  }
 }

packages/xo-server/src/xo-mixins/plugins.mjs

@@ -33,7 +33,7 @@ export default class {
         plugins =>
           Promise.all(
             plugins.map(async plugin => {
-              await this._pluginsMetadata.save(plugin)
+              await this._pluginsMetadata.update(plugin)
               if (plugin.configuration !== undefined && this._plugins[plugin.id] !== undefined) {
                 await this.configurePlugin(plugin.id, plugin.configuration)
               }
@@ -88,7 +88,7 @@ export default class {
       ;({ autoload, configuration } = metadata)
     } else {
       log.info(`[NOTICE] register plugin ${name} for the first time`)
-      await this._pluginsMetadata.save({
+      await this._pluginsMetadata.update({
         id,
         autoload,
       })