From 9e37f3f586bcb0d21ee3b7ab0520051957000194 Mon Sep 17 00:00:00 2001
From: Julien Fontanet <julien.fontanet@isonoe.net>
Date: Fri, 11 Sep 2020 11:10:25 +0200
Subject: [PATCH] feat(xo-web/new VM): hide missing VDIs

See #5222

Related to 15bc30a2d
---
 CHANGELOG.unreleased.md                    | 3 ++-
 packages/xo-web/src/xo-app/new-vm/index.js | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index d5ec84154..81534b117 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -8,6 +8,7 @@
 > Users must be able to say: “Nice enhancement, I'm eager to test it”
 
 - [VM Import] Make the `Description` field optional (PR [#5258](https://github.com/vatesfr/xen-orchestra/pull/5258))
+- [New VM] Hide missing ISOs in selector [#5222](https://github.com/vatesfr/xen-orchestra/issues/5222)
 
 ### Bug fixes
 
@@ -30,4 +31,4 @@
 >
 > In case of conflict, the highest (lowest in previous list) `$version` wins.
 
-- xo-web patch
+- xo-web minor
diff --git a/packages/xo-web/src/xo-app/new-vm/index.js b/packages/xo-web/src/xo-app/new-vm/index.js
index ce1bfec67..892de976a 100644
--- a/packages/xo-web/src/xo-app/new-vm/index.js
+++ b/packages/xo-web/src/xo-app/new-vm/index.js
@@ -223,6 +223,8 @@ class Vif extends BaseComponent {
 
 // =============================================================================
 
+const isVdiPresent = vdi => !vdi.missing
+
 @addSubscriptions({
   resourceSets: subscribeResourceSets,
   user: subscribeCurrentUser,
@@ -1315,6 +1317,7 @@ export default class NewVm extends BaseComponent {
                     <SelectVdi
                       disabled={installMethod !== 'ISO'}
                       onChange={this._linkState('installIso')}
+                      predicate={isVdiPresent}
                       srPredicate={this._getIsoPredicate()}
                       value={installIso}
                     />
@@ -1322,6 +1325,7 @@ export default class NewVm extends BaseComponent {
                     <SelectResourceSetsVdi
                       disabled={installMethod !== 'ISO'}
                       onChange={this._linkState('installIso')}
+                      predicate={isVdiPresent}
                       resourceSet={this._getResolvedResourceSet()}
                       srPredicate={this._getIsoPredicate()}
                       value={installIso}