From b71f4f68001145eee2387aeba4bd6c86f2717d9f Mon Sep 17 00:00:00 2001 From: Pierre Donias Date: Wed, 20 Mar 2019 09:43:06 +0100 Subject: [PATCH] fix(xo-web/home): always sort by name_label as a secondary sort (#4047) Fixes #3983 --- CHANGELOG.unreleased.md | 2 ++ packages/xo-web/src/xo-app/home/index.js | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index 37ae4a32f..fdb21957e 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -4,6 +4,8 @@ ### Bug fixes +- [Home] Always sort the items by their names as a secondary sort criteria [#3983](https://github.com/vatesfr/xen-orchestra/issues/3983) (PR [#4047](https://github.com/vatesfr/xen-orchestra/pull/4047)) + ### Released packages - xo-server v5.38.0 diff --git a/packages/xo-web/src/xo-app/home/index.js b/packages/xo-web/src/xo-app/home/index.js index 7cb139cce..0e88dbcea 100644 --- a/packages/xo-web/src/xo-app/home/index.js +++ b/packages/xo-web/src/xo-app/home/index.js @@ -674,7 +674,10 @@ export default class Home extends Component { _getFilteredItems = createSort( createFilter(() => this.props.items, this._getFilterFunction), - () => this.state.sortBy, + createSelector( + () => this.state.sortBy, + sortBy => [sortBy, 'name_label'] + ), () => this.state.sortOrder )