NuKVM/xen-orchestra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimization for empty arrays.

Browse Source
This commit is contained in:
Julien Fontanet 2015-06-23 09:13:43 +02:00
parent 9cb4de2ea8
commit bb1ea4e4d0
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
packages/xen-api/src/index.js
View File

@ -125,6 +125,10 @@ let getNotConnectedPromise = function () {
const OPAQUE_REF_RE = /^OpaqueRef:/
// -------------------------------------------------------------------
const EMPTY_ARRAY = []
// ===================================================================
const MAX_TRIES = 5
@ -381,24 +385,28 @@ export class Xapi extends EventEmitter {
// Creates resolved properties.
forEach(object, function resolveObject (value, key, object) {
if (isArray(value)) {
// Do not create an array of links unless it is known this is
// an array of refs.
if (value.length && !OPAQUE_REF_RE.test(value)) {
return
}
if (!value.length) {
// If the array is empty, it isn't possible to be sure that
// it is not supposed to contain links, therefore, in
// benefice of the doubt, a resolved property is defined.
defineProperty(object, '$' + key, {
value: EMPTY_ARRAY
})
defineProperty(object, '$' + key, {
get () {
return map(value, (ref) => objectsByRefs[ref])
}
})
// Minor memory optimization, use the same empty array for
// everyone.
object[key] = EMPTY_ARRAY
} else if (OPAQUE_REF_RE.test(value)) {
// This is an array of refs.
defineProperty(object, '$' + key, {
get: () => map(value, (ref) => objectsByRefs[ref])
})
}
} else if (isObject(value)) {
forEach(value, resolveObject)
} else if (OPAQUE_REF_RE.test(value)) {
defineProperty(object, '$' + key, {
get () {
return objectsByRefs[value]
}
get: () => objectsByRefs[value]
})
}
})