NuKVM/xen-orchestra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(xo-server/backup-ng): use getRemoteWithCredentials (#5315)

Browse Source 
Introduced in #4907

Fix #5253

Otherwise the handler will be incorrectly defined due to the obfuscation of credentials.
This commit is contained in:
Nicolas Raynaud 2020-10-06 18:13:27 +02:00 committed by GitHub
parent 9d261aae76
commit bf12c3ff74
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.unreleased.md
View File

@ -21,6 +21,7 @@
- [Self/VDI migration] Fix hidden VDI after migration (PR [#5296](https://github.com/vatesfr/xen-orchestra/pull/5296)) - [Self/VDI migration] Fix hidden VDI after migration (PR [#5296](https://github.com/vatesfr/xen-orchestra/pull/5296))
- [Self/VDI migration] Fix `not enough permissions` error (PR [#5299](https://github.com/vatesfr/xen-orchestra/pull/5299)) - [Self/VDI migration] Fix `not enough permissions` error (PR [#5299](https://github.com/vatesfr/xen-orchestra/pull/5299))
- [Home] Hide backup filter for non-admin users [#5285](https://github.com/vatesfr/xen-orchestra/issues/5285) (PR [#5264](https://github.com/vatesfr/xen-orchestra/pull/5264)) - [Home] Hide backup filter for non-admin users [#5285](https://github.com/vatesfr/xen-orchestra/issues/5285) (PR [#5264](https://github.com/vatesfr/xen-orchestra/pull/5264))
- [Backup/S3] Fix request signature error [#5253](https://github.com/vatesfr/xen-orchestra/issues/5253) (PR[#5315](https://github.com/vatesfr/xen-orchestra/pull/5315))
### Packages to release ### Packages to release

2
packages/xo-server/src/xo-mixins/backups-ng/index.js
View File

@ -710,7 +710,7 @@ export default class BackupNg {
const srs = srIds.map(id => app.getXapiObject(id, 'SR')) const srs = srIds.map(id => app.getXapiObject(id, 'SR'))
const remotes = await Promise.all( const remotes = await Promise.all(
remoteIds.map(async id => { remoteIds.map(async id => {
const remote = await app.getRemote(id) const remote = await app.getRemoteWithCredentials(id)
if (remote.proxy !== undefined) { if (remote.proxy !== undefined) {
throw new Error( throw new Error(
`The remote ${remote.name} must not be linked to a proxy` `The remote ${remote.name} must not be linked to a proxy`