From c705051a892f513f3e2855da50da2743fb8c41c0 Mon Sep 17 00:00:00 2001
From: Thierry Goettelmann <thierry@byscripts.info>
Date: Tue, 11 Jul 2023 14:56:03 +0200
Subject: [PATCH] chore(lite): use injection keys (#6898)

Using injection keys for `provide`/`inject` to prevent errors and code
repetition.
---
 .../lite/src/components/RouterTab.vue         |  7 +-
 .../src/components/charts/ChartSummary.vue    | 10 +--
 .../src/components/charts/LinearChart.vue     | 26 +++----
 .../lite/src/components/form/FormCheckbox.vue | 19 +++--
 .../lite/src/components/form/FormInput.vue    | 28 +++++---
 .../src/components/form/FormInputWrapper.vue  | 21 ++++--
 .../lite/src/components/form/FormRadio.vue    |  5 +-
 .../lite/src/components/form/FormSelect.vue   |  5 +-
 .../lite/src/components/form/FormTextarea.vue |  5 +-
 .../lite/src/components/form/FormToggle.vue   |  5 +-
 .../lite/src/components/menu/AppMenu.vue      | 31 +++++---
 .../lite/src/components/menu/MenuItem.vue     | 36 ++++++----
 .../src/components/menu/MenuSeparator.vue     |  8 ++-
 .../dashboard/PoolDashboardNetworkChart.vue   |  6 +-
 .../pool/dashboard/cpuUsage/HostsCpuUsage.vue |  9 ++-
 .../dashboard/cpuUsage/PoolCpuUsageChart.vue  | 10 ++-
 .../pool/dashboard/cpuUsage/VmsCpuUsage.vue   | 17 +++--
 .../pool/dashboard/ramUsage/HostsRamUsage.vue |  7 +-
 .../pool/dashboard/ramUsage/PoolRamUsage.vue  | 12 ++--
 .../pool/dashboard/ramUsage/VmsRamUsage.vue   | 17 +++--
 .../lite/src/components/ui/UiActionButton.vue | 22 ++++--
 .../lite/src/components/ui/UiButton.vue       | 44 +++++++++---
 .../lite/src/components/ui/UiButtonGroup.vue  | 19 +++--
 .../lite/src/components/ui/UiCardGroup.vue    |  5 +-
 .../lite/src/components/ui/UiTab.vue          |  7 +-
 .../lite/src/components/ui/UiTabBar.vue       |  5 +-
 @xen-orchestra/lite/src/types/chart.ts        |  2 +
 .../lite/src/types/injection-keys.ts          | 71 ++++++++++++++++++-
 .../lite/src/views/pool/PoolDashboardView.vue | 11 ++-
 29 files changed, 321 insertions(+), 149 deletions(-)

diff --git a/@xen-orchestra/lite/src/components/RouterTab.vue b/@xen-orchestra/lite/src/components/RouterTab.vue
index e8c39e414..344eb5873 100644
--- a/@xen-orchestra/lite/src/components/RouterTab.vue
+++ b/@xen-orchestra/lite/src/components/RouterTab.vue
@@ -11,7 +11,8 @@
 </template>
 
 <script lang="ts" setup>
-import { type ComputedRef, computed, inject } from "vue";
+import { IK_TAB_BAR_DISABLED } from "@/types/injection-keys";
+import { computed, inject } from "vue";
 import type { RouteLocationRaw } from "vue-router";
 import UiTab from "@/components/ui/UiTab.vue";
 
@@ -20,8 +21,8 @@ defineProps<{
   disabled?: boolean;
 }>();
 
-const isTabBarDisabled = inject<ComputedRef<boolean>>(
-  "isTabBarDisabled",
+const isTabBarDisabled = inject(
+  IK_TAB_BAR_DISABLED,
   computed(() => false)
 );
 </script>
diff --git a/@xen-orchestra/lite/src/components/charts/ChartSummary.vue b/@xen-orchestra/lite/src/components/charts/ChartSummary.vue
index 712312c73..ae68c535f 100644
--- a/@xen-orchestra/lite/src/components/charts/ChartSummary.vue
+++ b/@xen-orchestra/lite/src/components/charts/ChartSummary.vue
@@ -21,7 +21,8 @@
 
 <script lang="ts" setup>
 import { percent } from "@/libs/utils";
-import { computed, type ComputedRef, inject } from "vue";
+import { IK_CHART_VALUE_FORMATTER } from "@/types/injection-keys";
+import { computed, inject } from "vue";
 
 const props = defineProps<{
   total: number;
@@ -34,9 +35,10 @@ const freePercent = computed(() =>
   percent(props.total - props.used, props.total)
 );
 
-const valueFormatter = inject("valueFormatter") as ComputedRef<
-  (value: number) => string
->;
+const valueFormatter = inject(
+  IK_CHART_VALUE_FORMATTER,
+  computed(() => (value) => value.toString())
+);
 </script>
 
 <style lang="postcss" scoped>
diff --git a/@xen-orchestra/lite/src/components/charts/LinearChart.vue b/@xen-orchestra/lite/src/components/charts/LinearChart.vue
index a4596ba17..5facee7a6 100644
--- a/@xen-orchestra/lite/src/components/charts/LinearChart.vue
+++ b/@xen-orchestra/lite/src/components/charts/LinearChart.vue
@@ -6,11 +6,11 @@
 </template>
 
 <script lang="ts" setup>
+import UiCard from "@/components/ui/UiCard.vue";
+import type { LinearChartData, ValueFormatter } from "@/types/chart";
+import { IK_CHART_VALUE_FORMATTER } from "@/types/injection-keys";
 import { utcFormat } from "d3-time-format";
 import type { EChartsOption } from "echarts";
-import { computed, provide } from "vue";
-import VueCharts from "vue-echarts";
-import type { LinearChartData } from "@/types/chart";
 import { LineChart } from "echarts/charts";
 import {
   GridComponent,
@@ -20,8 +20,8 @@ import {
 } from "echarts/components";
 import { use } from "echarts/core";
 import { CanvasRenderer } from "echarts/renderers";
-import type { OptionDataValue } from "echarts/types/src/util/types";
-import UiCard from "@/components/ui/UiCard.vue";
+import { computed, provide } from "vue";
+import VueCharts from "vue-echarts";
 
 const Y_AXIS_MAX_VALUE = 200;
 
@@ -29,23 +29,23 @@ const props = defineProps<{
   title?: string;
   subtitle?: string;
   data: LinearChartData;
-  valueFormatter?: (value: number) => string;
+  valueFormatter?: ValueFormatter;
   maxValue?: number;
 }>();
 
-const valueFormatter = computed(() => {
+const valueFormatter = computed<ValueFormatter>(() => {
   const formatter = props.valueFormatter;
 
-  return (value: OptionDataValue | OptionDataValue[]) => {
-    if (formatter) {
-      return formatter(value as number);
+  return (value) => {
+    if (formatter === undefined) {
+      return value.toString();
     }
 
-    return value.toString();
+    return formatter(value);
   };
 });
 
-provide("valueFormatter", valueFormatter);
+provide(IK_CHART_VALUE_FORMATTER, valueFormatter);
 
 use([
   CanvasRenderer,
@@ -65,7 +65,7 @@ const option = computed<EChartsOption>(() => ({
     data: props.data.map((series) => series.label),
   },
   tooltip: {
-    valueFormatter: valueFormatter.value,
+    valueFormatter: (v) => valueFormatter.value(v as number),
   },
   xAxis: {
     type: "time",
diff --git a/@xen-orchestra/lite/src/components/form/FormCheckbox.vue b/@xen-orchestra/lite/src/components/form/FormCheckbox.vue
index 462d516b4..9f24666f0 100644
--- a/@xen-orchestra/lite/src/components/form/FormCheckbox.vue
+++ b/@xen-orchestra/lite/src/components/form/FormCheckbox.vue
@@ -19,7 +19,12 @@
 </template>
 
 <script lang="ts" setup>
-import { type HTMLAttributes, computed, inject, ref } from "vue";
+import {
+  IK_FORM_HAS_LABEL,
+  IK_FORM_LABEL_DISABLED,
+  IK_CHECKBOX_TYPE,
+} from "@/types/injection-keys";
+import { type HTMLAttributes, computed, inject } from "vue";
 import { faCheck, faCircle, faMinus } from "@fortawesome/free-solid-svg-icons";
 import { useVModel } from "@vueuse/core";
 import UiIcon from "@/components/ui/icon/UiIcon.vue";
@@ -37,9 +42,15 @@ const emit = defineEmits<{
 }>();
 
 const value = useVModel(props, "modelValue", emit);
-const type = inject<"checkbox" | "radio" | "toggle">("inputType", "checkbox");
-const hasLabel = inject("hasLabel", false);
-const isLabelDisabled = inject("isLabelDisabled", ref(false));
+const type = inject(IK_CHECKBOX_TYPE, "checkbox");
+const hasLabel = inject(
+  IK_FORM_HAS_LABEL,
+  computed(() => false)
+);
+const isLabelDisabled = inject(
+  IK_FORM_LABEL_DISABLED,
+  computed(() => false)
+);
 const icon = computed(() => {
   if (type !== "checkbox") {
     return faCircle;
diff --git a/@xen-orchestra/lite/src/components/form/FormInput.vue b/@xen-orchestra/lite/src/components/form/FormInput.vue
index adb20783d..04504ea6d 100644
--- a/@xen-orchestra/lite/src/components/form/FormInput.vue
+++ b/@xen-orchestra/lite/src/components/form/FormInput.vue
@@ -48,19 +48,24 @@
 </template>
 
 <script lang="ts" setup>
+import UiIcon from "@/components/ui/icon/UiIcon.vue";
+import type { Color } from "@/types";
+import {
+  IK_FORM_INPUT_COLOR,
+  IK_FORM_LABEL_DISABLED,
+  IK_INPUT_TYPE,
+} from "@/types/injection-keys";
+import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
+import { faAngleDown } from "@fortawesome/free-solid-svg-icons";
+import { useTextareaAutosize, useVModel } from "@vueuse/core";
 import {
-  type HTMLAttributes,
   computed,
+  type HTMLAttributes,
   inject,
   nextTick,
   ref,
   watch,
 } from "vue";
-import type { Color } from "@/types";
-import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
-import { faAngleDown } from "@fortawesome/free-solid-svg-icons";
-import { useTextareaAutosize, useVModel } from "@vueuse/core";
-import UiIcon from "@/components/ui/icon/UiIcon.vue";
 
 defineOptions({ inheritAttrs: false });
 
@@ -90,17 +95,20 @@ const value = useVModel(props, "modelValue", emit);
 const isEmpty = computed(
   () => props.modelValue == null || String(props.modelValue).trim() === ""
 );
-const inputType = inject("inputType", "input");
-const isLabelDisabled = inject("isLabelDisabled", ref(false));
+const inputType = inject(IK_INPUT_TYPE, "input");
+const isLabelDisabled = inject(
+  IK_FORM_LABEL_DISABLED,
+  computed(() => false)
+);
 const parentColor = inject(
-  "color",
+  IK_FORM_INPUT_COLOR,
   computed(() => undefined)
 );
 
 const wrapperClass = computed(() => [
   `form-${inputType}`,
   {
-    disabled: props.disabled || isLabelDisabled.value,
+    disabled: props.disabled === true || isLabelDisabled.value,
     empty: isEmpty.value,
   },
 ]);
diff --git a/@xen-orchestra/lite/src/components/form/FormInputWrapper.vue b/@xen-orchestra/lite/src/components/form/FormInputWrapper.vue
index 9ef8cff7d..da1b0a048 100644
--- a/@xen-orchestra/lite/src/components/form/FormInputWrapper.vue
+++ b/@xen-orchestra/lite/src/components/form/FormInputWrapper.vue
@@ -17,9 +17,14 @@
 </template>
 
 <script lang="ts" setup>
-import { computed, provide, useSlots } from "vue";
-import { faCircleExclamation } from "@fortawesome/free-solid-svg-icons";
 import UiIcon from "@/components/ui/icon/UiIcon.vue";
+import {
+  IK_FORM_HAS_LABEL,
+  IK_FORM_INPUT_COLOR,
+  IK_FORM_LABEL_DISABLED,
+} from "@/types/injection-keys";
+import { faCircleExclamation } from "@fortawesome/free-solid-svg-icons";
+import { computed, provide, useSlots } from "vue";
 
 const slots = useSlots();
 
@@ -29,10 +34,14 @@ const props = defineProps<{
   warning?: string;
 }>();
 
-provide("hasLabel", slots.label !== undefined);
 provide(
-  "isLabelDisabled",
-  computed(() => props.disabled)
+  IK_FORM_HAS_LABEL,
+  computed(() => slots.label !== undefined)
+);
+
+provide(
+  IK_FORM_LABEL_DISABLED,
+  computed(() => props.disabled ?? false)
 );
 
 const hasError = computed(
@@ -43,7 +52,7 @@ const hasWarning = computed(
 );
 
 provide(
-  "color",
+  IK_FORM_INPUT_COLOR,
   computed(() =>
     hasError.value ? "error" : hasWarning.value ? "warning" : undefined
   )
diff --git a/@xen-orchestra/lite/src/components/form/FormRadio.vue b/@xen-orchestra/lite/src/components/form/FormRadio.vue
index 2307f12cf..b9f6b39a2 100644
--- a/@xen-orchestra/lite/src/components/form/FormRadio.vue
+++ b/@xen-orchestra/lite/src/components/form/FormRadio.vue
@@ -3,8 +3,9 @@
 </template>
 
 <script lang="ts" setup>
-import { provide } from "vue";
 import FormCheckbox from "@/components/form/FormCheckbox.vue";
+import { IK_CHECKBOX_TYPE } from "@/types/injection-keys";
+import { provide } from "vue";
 
-provide("inputType", "radio");
+provide(IK_CHECKBOX_TYPE, "radio");
 </script>
diff --git a/@xen-orchestra/lite/src/components/form/FormSelect.vue b/@xen-orchestra/lite/src/components/form/FormSelect.vue
index b879ead14..45f8e47e7 100644
--- a/@xen-orchestra/lite/src/components/form/FormSelect.vue
+++ b/@xen-orchestra/lite/src/components/form/FormSelect.vue
@@ -5,10 +5,11 @@
 </template>
 
 <script lang="ts" setup>
-import { provide } from "vue";
 import FormInput from "@/components/form/FormInput.vue";
+import { IK_INPUT_TYPE } from "@/types/injection-keys";
+import { provide } from "vue";
 
-provide("inputType", "select");
+provide(IK_INPUT_TYPE, "select");
 </script>
 
 <style lang="postcss" scoped></style>
diff --git a/@xen-orchestra/lite/src/components/form/FormTextarea.vue b/@xen-orchestra/lite/src/components/form/FormTextarea.vue
index 10a80bb65..fbeb39d36 100644
--- a/@xen-orchestra/lite/src/components/form/FormTextarea.vue
+++ b/@xen-orchestra/lite/src/components/form/FormTextarea.vue
@@ -3,10 +3,11 @@
 </template>
 
 <script lang="ts" setup>
-import { provide } from "vue";
 import FormInput from "@/components/form/FormInput.vue";
+import { IK_INPUT_TYPE } from "@/types/injection-keys";
+import { provide } from "vue";
 
-provide("inputType", "textarea");
+provide(IK_INPUT_TYPE, "textarea");
 </script>
 
 <style lang="postcss" scoped></style>
diff --git a/@xen-orchestra/lite/src/components/form/FormToggle.vue b/@xen-orchestra/lite/src/components/form/FormToggle.vue
index 8f97609d8..a75205aa5 100644
--- a/@xen-orchestra/lite/src/components/form/FormToggle.vue
+++ b/@xen-orchestra/lite/src/components/form/FormToggle.vue
@@ -3,8 +3,9 @@
 </template>
 
 <script lang="ts" setup>
-import { provide } from "vue";
 import FormCheckbox from "@/components/form/FormCheckbox.vue";
+import { IK_CHECKBOX_TYPE } from "@/types/injection-keys";
+import { provide } from "vue";
 
-provide("inputType", "toggle");
+provide(IK_CHECKBOX_TYPE, "toggle");
 </script>
diff --git a/@xen-orchestra/lite/src/components/menu/AppMenu.vue b/@xen-orchestra/lite/src/components/menu/AppMenu.vue
index 79af80bd9..7e37ed3e5 100644
--- a/@xen-orchestra/lite/src/components/menu/AppMenu.vue
+++ b/@xen-orchestra/lite/src/components/menu/AppMenu.vue
@@ -14,9 +14,14 @@
 </template>
 
 <script lang="ts" setup>
-import { IK_MENU_TELEPORTED } from "@/types/injection-keys";
+import {
+  IK_CLOSE_MENU,
+  IK_MENU_DISABLED,
+  IK_MENU_HORIZONTAL,
+  IK_MENU_TELEPORTED,
+} from "@/types/injection-keys";
 import placementJs, { type Options } from "placement.js";
-import { inject, nextTick, provide, ref, toRef, unref, useSlots } from "vue";
+import { computed, inject, nextTick, provide, ref, useSlots } from "vue";
 import { onClickOutside, unrefElement, whenever } from "@vueuse/core";
 
 const props = defineProps<{
@@ -33,9 +38,18 @@ defineOptions({
 const slots = useSlots();
 const isOpen = ref(false);
 const menu = ref();
-const isParentHorizontal = inject("isMenuHorizontal", undefined);
-provide("isMenuHorizontal", toRef(props, "horizontal"));
-provide("isMenuDisabled", toRef(props, "disabled"));
+const isParentHorizontal = inject(
+  IK_MENU_HORIZONTAL,
+  computed(() => false)
+);
+provide(
+  IK_MENU_HORIZONTAL,
+  computed(() => props.horizontal ?? false)
+);
+provide(
+  IK_MENU_DISABLED,
+  computed(() => props.disabled ?? false)
+);
 let clearClickOutsideEvent: (() => void) | undefined;
 
 const hasTrigger = useSlots().trigger !== undefined;
@@ -50,9 +64,8 @@ whenever(
   () => !isOpen.value,
   () => clearClickOutsideEvent?.()
 );
-
-if (slots.trigger && !inject("closeMenu", false)) {
-  provide("closeMenu", () => (isOpen.value = false));
+if (slots.trigger && inject(IK_CLOSE_MENU, undefined) === undefined) {
+  provide(IK_CLOSE_MENU, () => (isOpen.value = false));
 }
 
 const open = (event: MouseEvent) => {
@@ -74,7 +87,7 @@ const open = (event: MouseEvent) => {
     placementJs(event.currentTarget as HTMLElement, unrefElement(menu), {
       placement:
         props.placement ??
-        (unref(isParentHorizontal) !== false ? "bottom-start" : "right-start"),
+        (isParentHorizontal.value ? "bottom-start" : "right-start"),
     });
   });
 };
diff --git a/@xen-orchestra/lite/src/components/menu/MenuItem.vue b/@xen-orchestra/lite/src/components/menu/MenuItem.vue
index cdb64445d..9eab1a8a3 100644
--- a/@xen-orchestra/lite/src/components/menu/MenuItem.vue
+++ b/@xen-orchestra/lite/src/components/menu/MenuItem.vue
@@ -10,7 +10,7 @@
     >
       <slot />
     </MenuTrigger>
-    <AppMenu v-else shadow :disabled="isDisabled">
+    <AppMenu v-else :disabled="isDisabled" shadow>
       <template #trigger="{ open, isOpen }">
         <MenuTrigger
           :active="isOpen"
@@ -33,13 +33,17 @@
 </template>
 
 <script lang="ts" setup>
-import { computed, inject, ref, unref } from "vue";
-import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
-import { faAngleDown, faAngleRight } from "@fortawesome/free-solid-svg-icons";
-import { noop } from "@vueuse/core";
 import AppMenu from "@/components/menu/AppMenu.vue";
 import MenuTrigger from "@/components/menu/MenuTrigger.vue";
 import UiIcon from "@/components/ui/icon/UiIcon.vue";
+import {
+  IK_CLOSE_MENU,
+  IK_MENU_DISABLED,
+  IK_MENU_HORIZONTAL,
+} from "@/types/injection-keys";
+import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
+import { faAngleDown, faAngleRight } from "@fortawesome/free-solid-svg-icons";
+import { computed, inject, ref } from "vue";
 
 const props = defineProps<{
   icon?: IconDefinition;
@@ -48,17 +52,25 @@ const props = defineProps<{
   busy?: boolean;
 }>();
 
-const isParentHorizontal = inject("isMenuHorizontal", false);
-const isMenuDisabled = inject("isMenuDisabled", false);
-const isDisabled = computed(() => props.disabled || unref(isMenuDisabled));
+const isParentHorizontal = inject(
+  IK_MENU_HORIZONTAL,
+  computed(() => false)
+);
+const isMenuDisabled = inject(
+  IK_MENU_DISABLED,
+  computed(() => false)
+);
+const isDisabled = computed(
+  () => props.disabled === true || isMenuDisabled.value
+);
 
 const submenuIcon = computed(() =>
-  unref(isParentHorizontal) ? faAngleDown : faAngleRight
+  isParentHorizontal.value ? faAngleDown : faAngleRight
 );
 
 const isHandlingClick = ref(false);
-const isBusy = computed(() => isHandlingClick.value || props.busy);
-const closeMenu = inject("closeMenu", noop);
+const isBusy = computed(() => isHandlingClick.value || props.busy === true);
+const closeMenu = inject(IK_CLOSE_MENU, undefined);
 
 const handleClick = async () => {
   if (isDisabled.value || isBusy.value) {
@@ -68,7 +80,7 @@ const handleClick = async () => {
   isHandlingClick.value = true;
   try {
     await props.onClick?.();
-    closeMenu();
+    closeMenu?.();
   } finally {
     isHandlingClick.value = false;
   }
diff --git a/@xen-orchestra/lite/src/components/menu/MenuSeparator.vue b/@xen-orchestra/lite/src/components/menu/MenuSeparator.vue
index c01668267..7d7eb9925 100644
--- a/@xen-orchestra/lite/src/components/menu/MenuSeparator.vue
+++ b/@xen-orchestra/lite/src/components/menu/MenuSeparator.vue
@@ -3,9 +3,13 @@
 </template>
 
 <script lang="ts" setup>
-import { inject } from "vue";
+import { IK_MENU_HORIZONTAL } from "@/types/injection-keys";
+import { computed, inject } from "vue";
 
-const horizontal = inject("isParentMenuHorizontal", false);
+const horizontal = inject(
+  IK_MENU_HORIZONTAL,
+  computed(() => false)
+);
 </script>
 
 <style lang="postcss" scoped>
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardNetworkChart.vue b/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardNetworkChart.vue
index 8e0d7d85d..91e37a52c 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardNetworkChart.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/PoolDashboardNetworkChart.vue
@@ -11,21 +11,19 @@
 </template>
 
 <script lang="ts" setup>
+import { IK_HOST_LAST_WEEK_STATS } from "@/types/injection-keys";
 import { computed, inject } from "vue";
 import { map } from "lodash-es";
 import { useI18n } from "vue-i18n";
 import LinearChart from "@/components/charts/LinearChart.vue";
-import type { FetchedStats } from "@/composables/fetch-stats.composable";
 import { formatSize } from "@/libs/utils";
 import type { HostStats } from "@/libs/xapi-stats";
 import type { LinearChartData } from "@/types/chart";
 import { RRD_STEP_FROM_STRING } from "@/libs/xapi-stats";
-import type { XenApiHost } from "@/libs/xen-api";
 
 const { t } = useI18n();
 
-const hostLastWeekStats =
-  inject<FetchedStats<XenApiHost, HostStats>>("hostLastWeekStats");
+const hostLastWeekStats = inject(IK_HOST_LAST_WEEK_STATS);
 
 const data = computed<LinearChartData>(() => {
   const stats = hostLastWeekStats?.stats?.value;
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/HostsCpuUsage.vue b/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/HostsCpuUsage.vue
index d21cc108d..9be13ce4c 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/HostsCpuUsage.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/HostsCpuUsage.vue
@@ -9,20 +9,19 @@
 </template>
 
 <script lang="ts" setup>
+import NoDataError from "@/components/NoDataError.vue";
 import UiCardTitle from "@/components/ui/UiCardTitle.vue";
 import UsageBar from "@/components/UsageBar.vue";
-import type { Stat } from "@/composables/fetch-stats.composable";
 import { getAvgCpuUsage } from "@/libs/utils";
-import type { HostStats } from "@/libs/xapi-stats";
 import { useHostStore } from "@/stores/host.store";
+import { IK_HOST_STATS } from "@/types/injection-keys";
 import { N_ITEMS } from "@/views/pool/PoolDashboardView.vue";
 import { computed, type ComputedRef, inject } from "vue";
-import NoDataError from "@/components/NoDataError.vue";
 
 const { hasError } = useHostStore().subscribe();
 
-const stats = inject<ComputedRef<Stat<HostStats>[]>>(
-  "hostStats",
+const stats = inject(
+  IK_HOST_STATS,
   computed(() => [])
 );
 
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/PoolCpuUsageChart.vue b/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/PoolCpuUsageChart.vue
index 8b04d6c97..6b91041b8 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/PoolCpuUsageChart.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/PoolCpuUsageChart.vue
@@ -12,20 +12,18 @@
 
 <script lang="ts" setup>
 import LinearChart from "@/components/charts/LinearChart.vue";
-import type { FetchedStats } from "@/composables/fetch-stats.composable";
 import type { HostStats } from "@/libs/xapi-stats";
 import { RRD_STEP_FROM_STRING } from "@/libs/xapi-stats";
-import type { XenApiHost } from "@/libs/xen-api";
 import { useHostStore } from "@/stores/host.store";
-import type { LinearChartData } from "@/types/chart";
+import type { LinearChartData, ValueFormatter } from "@/types/chart";
+import { IK_HOST_LAST_WEEK_STATS } from "@/types/injection-keys";
 import { sumBy } from "lodash-es";
 import { computed, inject } from "vue";
 import { useI18n } from "vue-i18n";
 
 const { t } = useI18n();
 
-const hostLastWeekStats =
-  inject<FetchedStats<XenApiHost, HostStats>>("hostLastWeekStats");
+const hostLastWeekStats = inject(IK_HOST_LAST_WEEK_STATS);
 
 const { records: hosts } = useHostStore().subscribe();
 
@@ -78,5 +76,5 @@ const data = computed<LinearChartData>(() => {
   ];
 });
 
-const customValueFormatter = (value: number) => `${value}%`;
+const customValueFormatter: ValueFormatter = (value) => `${value}%`;
 </script>
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/VmsCpuUsage.vue b/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/VmsCpuUsage.vue
index 51debba01..80966d2e9 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/VmsCpuUsage.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/cpuUsage/VmsCpuUsage.vue
@@ -9,20 +9,19 @@
 </template>
 
 <script lang="ts" setup>
-import UiCardTitle from "@/components/ui/UiCardTitle.vue";
-import { type ComputedRef, computed, inject } from "vue";
-import UsageBar from "@/components/UsageBar.vue";
-import type { Stat } from "@/composables/fetch-stats.composable";
-import { getAvgCpuUsage } from "@/libs/utils";
-import type { VmStats } from "@/libs/xapi-stats";
-import { N_ITEMS } from "@/views/pool/PoolDashboardView.vue";
 import NoDataError from "@/components/NoDataError.vue";
+import UiCardTitle from "@/components/ui/UiCardTitle.vue";
+import UsageBar from "@/components/UsageBar.vue";
+import { getAvgCpuUsage } from "@/libs/utils";
 import { useVmStore } from "@/stores/vm.store";
+import { IK_VM_STATS } from "@/types/injection-keys";
+import { N_ITEMS } from "@/views/pool/PoolDashboardView.vue";
+import { computed, type ComputedRef, inject } from "vue";
 
 const { hasError } = useVmStore().subscribe();
 
-const stats = inject<ComputedRef<Stat<VmStats>[]>>(
-  "vmStats",
+const stats = inject(
+  IK_VM_STATS,
   computed(() => [])
 );
 
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/HostsRamUsage.vue b/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/HostsRamUsage.vue
index a2d69924b..615dd8b00 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/HostsRamUsage.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/HostsRamUsage.vue
@@ -10,19 +10,18 @@
 
 <script lang="ts" setup>
 import UiCardTitle from "@/components/ui/UiCardTitle.vue";
+import { IK_HOST_STATS } from "@/types/injection-keys";
 import { type ComputedRef, computed, inject } from "vue";
 import UsageBar from "@/components/UsageBar.vue";
-import type { Stat } from "@/composables/fetch-stats.composable";
 import { formatSize, parseRamUsage } from "@/libs/utils";
-import type { HostStats } from "@/libs/xapi-stats";
 import { N_ITEMS } from "@/views/pool/PoolDashboardView.vue";
 import NoDataError from "@/components/NoDataError.vue";
 import { useHostStore } from "@/stores/host.store";
 
 const { hasError } = useHostStore().subscribe();
 
-const stats = inject<ComputedRef<Stat<HostStats>[]>>(
-  "hostStats",
+const stats = inject(
+  IK_HOST_STATS,
   computed(() => [])
 );
 
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/PoolRamUsage.vue b/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/PoolRamUsage.vue
index 6a7756c40..9fdc97286 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/PoolRamUsage.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/PoolRamUsage.vue
@@ -17,14 +17,12 @@
 <script lang="ts" setup>
 import LinearChart from "@/components/charts/LinearChart.vue";
 import SizeStatsSummary from "@/components/ui/SizeStatsSummary.vue";
-import type { FetchedStats } from "@/composables/fetch-stats.composable";
 import { formatSize, getHostMemory } from "@/libs/utils";
-import type { HostStats } from "@/libs/xapi-stats";
 import { RRD_STEP_FROM_STRING } from "@/libs/xapi-stats";
-import type { XenApiHost } from "@/libs/xen-api";
 import { useHostMetricsStore } from "@/stores/host-metrics.store";
 import { useHostStore } from "@/stores/host.store";
-import type { LinearChartData } from "@/types/chart";
+import type { LinearChartData, ValueFormatter } from "@/types/chart";
+import { IK_HOST_LAST_WEEK_STATS } from "@/types/injection-keys";
 import { sumBy } from "lodash-es";
 import { computed, inject } from "vue";
 import { useI18n } from "vue-i18n";
@@ -36,8 +34,7 @@ const { runningHosts } = hostStore.subscribe({ hostMetricsSubscription });
 
 const { t } = useI18n();
 
-const hostLastWeekStats =
-  inject<FetchedStats<XenApiHost, HostStats>>("hostLastWeekStats");
+const hostLastWeekStats = inject(IK_HOST_LAST_WEEK_STATS);
 
 const customMaxValue = computed(() =>
   sumBy(
@@ -96,5 +93,6 @@ const data = computed<LinearChartData>(() => {
   ];
 });
 
-const customValueFormatter = (value: number) => String(formatSize(value));
+const customValueFormatter: ValueFormatter = (value) =>
+  String(formatSize(value));
 </script>
diff --git a/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/VmsRamUsage.vue b/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/VmsRamUsage.vue
index a374608d2..91e68ab36 100644
--- a/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/VmsRamUsage.vue
+++ b/@xen-orchestra/lite/src/components/pool/dashboard/ramUsage/VmsRamUsage.vue
@@ -9,20 +9,19 @@
 </template>
 
 <script lang="ts" setup>
-import UiCardTitle from "@/components/ui/UiCardTitle.vue";
-import { type ComputedRef, computed, inject } from "vue";
-import UsageBar from "@/components/UsageBar.vue";
-import type { Stat } from "@/composables/fetch-stats.composable";
-import { formatSize, parseRamUsage } from "@/libs/utils";
-import type { VmStats } from "@/libs/xapi-stats";
-import { N_ITEMS } from "@/views/pool/PoolDashboardView.vue";
 import NoDataError from "@/components/NoDataError.vue";
+import UiCardTitle from "@/components/ui/UiCardTitle.vue";
+import UsageBar from "@/components/UsageBar.vue";
+import { formatSize, parseRamUsage } from "@/libs/utils";
 import { useVmStore } from "@/stores/vm.store";
+import { IK_VM_STATS } from "@/types/injection-keys";
+import { N_ITEMS } from "@/views/pool/PoolDashboardView.vue";
+import { computed, type ComputedRef, inject } from "vue";
 
 const { hasError } = useVmStore().subscribe();
 
-const stats = inject<ComputedRef<Stat<VmStats>[]>>(
-  "vmStats",
+const stats = inject(
+  IK_VM_STATS,
   computed(() => [])
 );
 
diff --git a/@xen-orchestra/lite/src/components/ui/UiActionButton.vue b/@xen-orchestra/lite/src/components/ui/UiActionButton.vue
index c64c5f105..f85155cff 100644
--- a/@xen-orchestra/lite/src/components/ui/UiActionButton.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiActionButton.vue
@@ -16,9 +16,13 @@
 </template>
 
 <script lang="ts" setup>
-import { computed, inject, unref } from "vue";
-import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
 import UiIcon from "@/components/ui/icon/UiIcon.vue";
+import {
+  IK_BUTTON_GROUP_BUSY,
+  IK_BUTTON_GROUP_DISABLED,
+} from "@/types/injection-keys";
+import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
+import { computed, inject } from "vue";
 
 const props = withDefaults(
   defineProps<{
@@ -30,11 +34,17 @@ const props = withDefaults(
   { busy: undefined, disabled: undefined }
 );
 
-const isGroupBusy = inject("isButtonGroupBusy", false);
-const isBusy = computed(() => props.busy ?? unref(isGroupBusy));
+const isGroupBusy = inject(
+  IK_BUTTON_GROUP_BUSY,
+  computed(() => false)
+);
+const isBusy = computed(() => props.busy ?? isGroupBusy.value);
 
-const isGroupDisabled = inject("isButtonGroupDisabled", false);
-const isDisabled = computed(() => props.disabled ?? unref(isGroupDisabled));
+const isGroupDisabled = inject(
+  IK_BUTTON_GROUP_DISABLED,
+  computed(() => false)
+);
+const isDisabled = computed(() => props.disabled ?? isGroupDisabled.value);
 </script>
 
 <style lang="postcss" scoped>
diff --git a/@xen-orchestra/lite/src/components/ui/UiButton.vue b/@xen-orchestra/lite/src/components/ui/UiButton.vue
index dffd50cb6..ced2e8312 100644
--- a/@xen-orchestra/lite/src/components/ui/UiButton.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiButton.vue
@@ -15,7 +15,14 @@
 
 <script lang="ts" setup>
 import UiSpinner from "@/components/ui/UiSpinner.vue";
-import { computed, inject, unref } from "vue";
+import {
+  IK_BUTTON_GROUP_BUSY,
+  IK_BUTTON_GROUP_COLOR,
+  IK_BUTTON_GROUP_DISABLED,
+  IK_BUTTON_GROUP_OUTLINED,
+  IK_BUTTON_GROUP_TRANSPARENT,
+} from "@/types/injection-keys";
+import { computed, inject } from "vue";
 import type { Color } from "@/types";
 import type { IconDefinition } from "@fortawesome/fontawesome-common-types";
 import UiIcon from "@/components/ui/icon/UiIcon.vue";
@@ -39,17 +46,32 @@ const props = withDefaults(
   }
 );
 
-const isGroupBusy = inject("isButtonGroupBusy", false);
-const isBusy = computed(() => props.busy ?? unref(isGroupBusy));
+const isGroupBusy = inject(
+  IK_BUTTON_GROUP_BUSY,
+  computed(() => false)
+);
+const isBusy = computed(() => props.busy ?? isGroupBusy.value);
 
-const isGroupDisabled = inject("isButtonGroupDisabled", false);
-const isDisabled = computed(() => props.disabled ?? unref(isGroupDisabled));
+const isGroupDisabled = inject(
+  IK_BUTTON_GROUP_DISABLED,
+  computed(() => false)
+);
+const isDisabled = computed(() => props.disabled ?? isGroupDisabled.value);
 
-const isGroupOutlined = inject("isButtonGroupOutlined", false);
-const isGroupTransparent = inject("isButtonGroupTransparent", false);
+const isGroupOutlined = inject(
+  IK_BUTTON_GROUP_OUTLINED,
+  computed(() => false)
+);
+const isGroupTransparent = inject(
+  IK_BUTTON_GROUP_TRANSPARENT,
+  computed(() => false)
+);
 
-const buttonGroupColor = inject("buttonGroupColor", "info");
-const buttonColor = computed(() => props.color ?? unref(buttonGroupColor));
+const buttonGroupColor = inject(
+  IK_BUTTON_GROUP_COLOR,
+  computed(() => "info")
+);
+const buttonColor = computed(() => props.color ?? buttonGroupColor.value);
 
 const className = computed(() => {
   return [
@@ -58,8 +80,8 @@ const className = computed(() => {
       busy: isBusy.value,
       active: props.active,
       disabled: isDisabled.value,
-      outlined: props.outlined ?? unref(isGroupOutlined),
-      transparent: props.transparent ?? unref(isGroupTransparent),
+      outlined: props.outlined ?? isGroupOutlined.value,
+      transparent: props.transparent ?? isGroupTransparent.value,
     },
   ];
 });
diff --git a/@xen-orchestra/lite/src/components/ui/UiButtonGroup.vue b/@xen-orchestra/lite/src/components/ui/UiButtonGroup.vue
index 494815f94..f384a69c9 100644
--- a/@xen-orchestra/lite/src/components/ui/UiButtonGroup.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiButtonGroup.vue
@@ -5,8 +5,15 @@
 </template>
 
 <script lang="ts" setup>
-import { computed, provide } from "vue";
 import type { Color } from "@/types";
+import {
+  IK_BUTTON_GROUP_BUSY,
+  IK_BUTTON_GROUP_COLOR,
+  IK_BUTTON_GROUP_DISABLED,
+  IK_BUTTON_GROUP_OUTLINED,
+  IK_BUTTON_GROUP_TRANSPARENT,
+} from "@/types/injection-keys";
+import { computed, provide } from "vue";
 
 const props = defineProps<{
   busy?: boolean;
@@ -17,23 +24,23 @@ const props = defineProps<{
   merge?: boolean;
 }>();
 provide(
-  "isButtonGroupBusy",
+  IK_BUTTON_GROUP_BUSY,
   computed(() => props.busy ?? false)
 );
 provide(
-  "isButtonGroupDisabled",
+  IK_BUTTON_GROUP_DISABLED,
   computed(() => props.disabled ?? false)
 );
 provide(
-  "buttonGroupColor",
+  IK_BUTTON_GROUP_COLOR,
   computed(() => props.color ?? "info")
 );
 provide(
-  "isButtonGroupOutlined",
+  IK_BUTTON_GROUP_OUTLINED,
   computed(() => props.outlined ?? false)
 );
 provide(
-  "isButtonGroupTransparent",
+  IK_BUTTON_GROUP_TRANSPARENT,
   computed(() => props.transparent ?? false)
 );
 </script>
diff --git a/@xen-orchestra/lite/src/components/ui/UiCardGroup.vue b/@xen-orchestra/lite/src/components/ui/UiCardGroup.vue
index 0d7cdb747..a94d62b59 100644
--- a/@xen-orchestra/lite/src/components/ui/UiCardGroup.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiCardGroup.vue
@@ -5,11 +5,12 @@
 </template>
 
 <script lang="ts" setup>
+import { IK_CARD_GROUP_VERTICAL } from "@/types/injection-keys";
 import { inject, provide } from "vue";
 
-const vertical = inject("isCardGroupVertical", false);
+const vertical = inject(IK_CARD_GROUP_VERTICAL, false);
 
-provide("isCardGroupVertical", !vertical);
+provide(IK_CARD_GROUP_VERTICAL, !vertical);
 </script>
 
 <style lang="postcss" scoped>
diff --git a/@xen-orchestra/lite/src/components/ui/UiTab.vue b/@xen-orchestra/lite/src/components/ui/UiTab.vue
index 66e983898..708217681 100644
--- a/@xen-orchestra/lite/src/components/ui/UiTab.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiTab.vue
@@ -9,7 +9,8 @@
 </template>
 
 <script lang="ts" setup>
-import { type ComputedRef, computed, inject } from "vue";
+import { IK_TAB_BAR_DISABLED } from "@/types/injection-keys";
+import { computed, inject } from "vue";
 
 withDefaults(
   defineProps<{
@@ -20,8 +21,8 @@ withDefaults(
   { tag: "span" }
 );
 
-const isTabBarDisabled = inject<ComputedRef<boolean>>(
-  "isTabBarDisabled",
+const isTabBarDisabled = inject(
+  IK_TAB_BAR_DISABLED,
   computed(() => false)
 );
 </script>
diff --git a/@xen-orchestra/lite/src/components/ui/UiTabBar.vue b/@xen-orchestra/lite/src/components/ui/UiTabBar.vue
index 974a98e01..243a418eb 100644
--- a/@xen-orchestra/lite/src/components/ui/UiTabBar.vue
+++ b/@xen-orchestra/lite/src/components/ui/UiTabBar.vue
@@ -5,6 +5,7 @@
 </template>
 
 <script lang="ts" setup>
+import { IK_TAB_BAR_DISABLED } from "@/types/injection-keys";
 import { computed, provide } from "vue";
 
 const props = defineProps<{
@@ -12,8 +13,8 @@ const props = defineProps<{
 }>();
 
 provide(
-  "isTabBarDisabled",
-  computed(() => props.disabled)
+  IK_TAB_BAR_DISABLED,
+  computed(() => props.disabled ?? false)
 );
 </script>
 
diff --git a/@xen-orchestra/lite/src/types/chart.ts b/@xen-orchestra/lite/src/types/chart.ts
index 791c02eaa..6958af099 100644
--- a/@xen-orchestra/lite/src/types/chart.ts
+++ b/@xen-orchestra/lite/src/types/chart.ts
@@ -5,3 +5,5 @@ export type LinearChartData = {
     value: number;
   }[];
 }[];
+
+export type ValueFormatter = (value: number) => string;
diff --git a/@xen-orchestra/lite/src/types/injection-keys.ts b/@xen-orchestra/lite/src/types/injection-keys.ts
index d4fb77969..92a1c5e47 100644
--- a/@xen-orchestra/lite/src/types/injection-keys.ts
+++ b/@xen-orchestra/lite/src/types/injection-keys.ts
@@ -1,3 +1,72 @@
-import type { InjectionKey } from "vue";
+import type { FetchedStats, Stat } from "@/composables/fetch-stats.composable";
+import type { HostStats, VmStats } from "@/libs/xapi-stats";
+import type { XenApiHost } from "@/libs/xen-api";
+import type { ValueFormatter } from "@/types/chart";
+import type { ComputedRef, InjectionKey } from "vue";
 
 export const IK_MENU_TELEPORTED = Symbol() as InjectionKey<boolean>;
+export const IK_TAB_BAR_DISABLED = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_CHART_VALUE_FORMATTER = Symbol() as InjectionKey<
+  ComputedRef<ValueFormatter>
+>;
+
+export const IK_INPUT_TYPE = Symbol() as InjectionKey<"select" | "textarea">;
+
+export const IK_CHECKBOX_TYPE = Symbol() as InjectionKey<
+  "checkbox" | "radio" | "toggle"
+>;
+
+export const IK_FORM_HAS_LABEL = Symbol() as InjectionKey<ComputedRef<boolean>>;
+
+export const IK_FORM_LABEL_DISABLED = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_FORM_INPUT_COLOR = Symbol() as InjectionKey<
+  ComputedRef<"success" | "error" | "warning" | "info" | undefined>
+>;
+
+export const IK_MENU_DISABLED = Symbol() as InjectionKey<ComputedRef<boolean>>;
+
+export const IK_MENU_HORIZONTAL = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_CLOSE_MENU = Symbol() as InjectionKey<() => void>;
+
+export const IK_HOST_STATS = Symbol() as InjectionKey<
+  ComputedRef<Stat<HostStats>[]>
+>;
+
+export const IK_VM_STATS = Symbol() as InjectionKey<
+  ComputedRef<Stat<VmStats>[]>
+>;
+
+export const IK_HOST_LAST_WEEK_STATS = Symbol() as InjectionKey<
+  FetchedStats<XenApiHost, HostStats>
+>;
+
+export const IK_BUTTON_GROUP_DISABLED = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_BUTTON_GROUP_BUSY = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_BUTTON_GROUP_OUTLINED = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_BUTTON_GROUP_TRANSPARENT = Symbol() as InjectionKey<
+  ComputedRef<boolean>
+>;
+
+export const IK_BUTTON_GROUP_COLOR = Symbol() as InjectionKey<
+  ComputedRef<"success" | "error" | "warning" | "info">
+>;
+
+export const IK_CARD_GROUP_VERTICAL = Symbol() as InjectionKey<boolean>;
diff --git a/@xen-orchestra/lite/src/views/pool/PoolDashboardView.vue b/@xen-orchestra/lite/src/views/pool/PoolDashboardView.vue
index a1661d096..c153b7f3a 100644
--- a/@xen-orchestra/lite/src/views/pool/PoolDashboardView.vue
+++ b/@xen-orchestra/lite/src/views/pool/PoolDashboardView.vue
@@ -33,6 +33,11 @@ export const N_ITEMS = 5;
 <script lang="ts" setup>
 import UiCardGroup from "@/components/ui/UiCardGroup.vue";
 import { useHostMetricsStore } from "@/stores/host-metrics.store";
+import {
+  IK_HOST_LAST_WEEK_STATS,
+  IK_HOST_STATS,
+  IK_VM_STATS,
+} from "@/types/injection-keys";
 import { differenceBy } from "lodash-es";
 import { provide, watch } from "vue";
 import UiCardComingSoon from "@/components/ui/UiCardComingSoon.vue";
@@ -77,9 +82,9 @@ const hostLastWeekStats = useFetchStats<XenApiHost, HostStats>(
   GRANULARITY.Hours
 );
 
-provide("hostStats", hostStats);
-provide("vmStats", vmStats);
-provide("hostLastWeekStats", hostLastWeekStats);
+provide(IK_HOST_STATS, hostStats);
+provide(IK_VM_STATS, vmStats);
+provide(IK_HOST_LAST_WEEK_STATS, hostLastWeekStats);
 
 watch(runningHosts, (hosts, previousHosts) => {
   // turned On