From d87210e903a69a6ff09af5d2ac270fec34322038 Mon Sep 17 00:00:00 2001
From: Florent BEAUCHAMP <florent.beauchamp@vates.fr>
Date: Wed, 28 Sep 2022 15:38:54 +0200
Subject: [PATCH] fix(xo-server): fix running replication job (#6437)

Introduced by 2d6b827fd
---
 CHANGELOG.unreleased.md                               | 1 +
 packages/xo-server/src/xo-mixins/backups-ng/index.mjs | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index 2e906d9b9..39eb9e234 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -23,4 +23,5 @@
 
 <!--packages-start-->
 
+- xo-server patch
 <!--packages-end-->
diff --git a/packages/xo-server/src/xo-mixins/backups-ng/index.mjs b/packages/xo-server/src/xo-mixins/backups-ng/index.mjs
index 06733673c..c8e4c6db9 100644
--- a/packages/xo-server/src/xo-mixins/backups-ng/index.mjs
+++ b/packages/xo-server/src/xo-mixins/backups-ng/index.mjs
@@ -229,11 +229,17 @@ export default class BackupNg {
               }
             }),
           ])
-          if (Object.keys(remotes).length === 0) {
+
+          // Fails the job if all remotes are disabled
+          //
+          // TODO: integrate each failure in its own tasks and still proceed
+          // with other tasks like rolling snapshot and replication.
+          if (remoteIds.length > 0 && Object.keys(remotes).length === 0) {
             const error = new Error(`couldn't instantiate any remote`)
             error.errors = remoteErrors
             throw error
           }
+
           // update remotes list with only the enabled remotes
           job.remotes = {
             id: {