From debca09e2c70138f23638a0b4be2b156e82adce6 Mon Sep 17 00:00:00 2001
From: BCedric <bois.cedric2303@gmail.com>
Date: Tue, 23 May 2017 11:11:14 +0200
Subject: [PATCH] remove _getItems, rename VMGroupItem => VmGroupItem

---
 src/common/xo/index.js           |  4 ++--
 src/xo-app/home/index.js         | 35 ++++++++++++++++++--------------
 src/xo-app/home/vm-group-item.js |  7 +++----
 3 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/src/common/xo/index.js b/src/common/xo/index.js
index 8ef971bca..b2af17008 100644
--- a/src/common/xo/index.js
+++ b/src/common/xo/index.js
@@ -245,8 +245,6 @@ export const subscribeScheduleTable = createSubscription(() => _call('scheduler.
 
 export const subscribeSchedules = createSubscription(() => _call('schedule.getAll'))
 
-export const subscribeVMGroups = createSubscription(() => _call('vmGroup.get'))
-
 export const subscribeServers = createSubscription(invoke(
   fpSortBy('host'),
   sort => () => _call('server.getAll').then(sort)
@@ -277,6 +275,8 @@ export const subscribeIpPools = createSubscription(() => _call('ipPool.getAll'))
 
 export const subscribeResourceCatalog = createSubscription(() => _call('cloud.getResourceCatalog'))
 
+export const subscribeVmGroups = createSubscription(() => _call('vmGroup.get'))
+
 const xosanSubscriptions = {}
 export const subscribeIsInstallingXosan = (pool, cb) => {
   const poolId = resolveId(pool)
diff --git a/src/xo-app/home/index.js b/src/xo-app/home/index.js
index 0dfc0276e..330bb14e5 100644
--- a/src/xo-app/home/index.js
+++ b/src/xo-app/home/index.js
@@ -52,7 +52,7 @@ import {
   stopHosts,
   stopVms,
   subscribeServers,
-  subscribeVMGroups
+  subscribeVmGroups
 } from 'xo'
 import { Container, Row, Col } from 'grid'
 import {
@@ -87,8 +87,8 @@ import {
 import styles from './index.css'
 import HostItem from './host-item'
 import PoolItem from './pool-item'
-import VmItem from './vm-item'
 import VmGroupItem from './vm-group-item'
+import VmItem from './vm-item'
 import TemplateItem from './template-item'
 import SrItem from './sr-item'
 
@@ -223,21 +223,28 @@ const DEFAULT_TYPE = 'VM'
 
 @addSubscriptions({
   servers: subscribeServers,
-  VMGroups: subscribeVMGroups
+  vmGroups: subscribeVmGroups
 })
 @connectStore(() => {
   const noServersConnected = invoke(
     createGetObjectsOfType('host'),
     hosts => state => isEmpty(hosts(state))
   )
-  const type = (_, props) => props.location.query.t || DEFAULT_TYPE
+  const getType = (_, props) => props.location.query.t || DEFAULT_TYPE
+  const getObjectsByType = createGetObjectsOfType(getType)
 
-  return {
-    areObjectsFetched,
-    items: createGetObjectsOfType(type),
-    noServersConnected,
-    type,
-    user: getUser
+  return (state, props) => {
+    const type = getType(state, props)
+
+    return {
+      areObjectsFetched: areObjectsFetched(state, props),
+      items: type === 'VM-group'
+        ? props.vmGroups
+        : getObjectsByType(state, props),
+      noServersConnected: noServersConnected(state, props),
+      type,
+      user: getUser(state, props)
+    }
   }
 })
 export default class Home extends Component {
@@ -281,9 +288,7 @@ export default class Home extends Component {
     }
   }
 
-  _getItems = () => this.props.type === 'VM-group' ? this.props.VMGroups : this.props.items
-
-  _getNumberOfItems = createCounter(() => this._getItems())
+  _getNumberOfItems = createCounter(() => this.props.items)
   _getNumberOfSelectedItems = createCounter(
     () => this.state.selectedItems,
     [ identity ]
@@ -403,7 +408,7 @@ export default class Home extends Component {
 
   _getFilteredItems = createSort(
     createFilter(
-      () => this._getItems(),
+      () => this.props.items,
       this._getFilterFunction
     ),
     () => this.state.sortBy,
@@ -717,7 +722,7 @@ export default class Home extends Component {
     const {
       type
     } = this.props
-    const items = this._getItems()
+    const items = this.props.items
 
     const options = OPTIONS[type]
     const {
diff --git a/src/xo-app/home/vm-group-item.js b/src/xo-app/home/vm-group-item.js
index 785be3c77..c136e0f46 100644
--- a/src/xo-app/home/vm-group-item.js
+++ b/src/xo-app/home/vm-group-item.js
@@ -10,8 +10,8 @@ import { Text } from 'editable'
 
 import styles from './index.css'
 
-export default class VMGroupItem extends Component {
-  _toggleExpanded = () => this.setState({ expanded: !this.state.expanded })
+export default class VmGroupItem extends Component {
+  toggleState = stateField => () => this.setState({ [stateField]: !this.state[stateField] })
   _onSelect = () => this.props.onSelect(this.props.item.id)
   _setNameLabel = nameLabel => { /* TODO */ }
   _removeTag = tag => { /* TODO */ }
@@ -43,8 +43,7 @@ export default class VMGroupItem extends Component {
             </EllipsisContainer>
           </Col>
           <Col mediumSize={1} className={styles.itemExpandRow}>
-            <a className={styles.itemExpandButton}
-              onClick={this._toggleExpanded}>
+            <a className={styles.itemExpandButton} onClick={this.toggleState('expanded')}>
               <Icon icon='nav' fixedWidth />&nbsp;&nbsp;&nbsp;
             </a>
           </Col>