From e0987059d3a9ca1284bee0ce0b2566a1dad51398 Mon Sep 17 00:00:00 2001 From: Pierre Donias Date: Fri, 20 Nov 2020 14:10:58 +0100 Subject: [PATCH] =?UTF-8?q?fix(xo-server-auth-ldap):=20typo=20defaults=20?= =?UTF-8?q?=E2=86=92=20default=20(#5388)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "Check certificate" option's default value was incorrectly set in the UI. So if it was left untouched by the user (showing as OFF since `undefined`), it would be saved as `undefined`, and then fallback to the actual default value (`true`) when used in the code. So it would try to check the certificate even though the user didn't want to. --- CHANGELOG.unreleased.md | 1 + packages/xo-server-auth-ldap/src/index.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index bdff7684f..e2bdf6ad3 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -37,6 +37,7 @@ > > In case of conflict, the highest (lowest in previous list) `$version` wins. +- xo-server-auth-ldap patch - @vates/multi-key-map minor - @xen-orchestra/fs patch - xo-server minor diff --git a/packages/xo-server-auth-ldap/src/index.js b/packages/xo-server-auth-ldap/src/index.js index 974750e67..49ad93616 100644 --- a/packages/xo-server-auth-ldap/src/index.js +++ b/packages/xo-server-auth-ldap/src/index.js @@ -53,7 +53,7 @@ If not specified, it will use a default set of well-known CAs. description: "Enforce the validity of the server's certificates. You can disable it when connecting to servers that use a self-signed certificate.", type: 'boolean', - defaults: DEFAULTS.checkCertificate, + default: DEFAULTS.checkCertificate, }, startTls: { title: 'Use StartTLS',