From e6c8d6cc7d952c0e5337dd27c131f4b29d92aeb2 Mon Sep 17 00:00:00 2001 From: badrAZ Date: Mon, 3 Feb 2020 09:37:54 +0100 Subject: [PATCH] fix(xo-server/proxy.update): only check address/VM duplicates on change (#4723) See xoa#49 --- packages/xo-server/src/xo-mixins/proxies.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/xo-server/src/xo-mixins/proxies.js b/packages/xo-server/src/xo-mixins/proxies.js index 9630197d4..f9eccadfa 100644 --- a/packages/xo-server/src/xo-mixins/proxies.js +++ b/packages/xo-server/src/xo-mixins/proxies.js @@ -109,10 +109,12 @@ export default class Proxy { @synchronizedWrite async updateProxy(id, { address, authenticationToken, name, vmUuid }) { - // TODO: don't throw if these properties aren't modified - await this._throwIfRegistered(address, vmUuid) - const proxy = await this._getProxy(id) + await this._throwIfRegistered( + proxy.address !== address ? address : undefined, + proxy.vm !== vmUuid ? vmUuid : undefined + ) + patch(proxy, { address, authenticationToken, name, vmUuid }) return this._db .update(proxy)