fix(xo-server/delta NG): handle removed disks (#3479)

CHANGELOG.md

@@ -6,6 +6,8 @@
 
 ### Bug fixes
 
+- [Backup NG] Fix `Cannot read property 'uuid' of undefined` when a disk is removed from a VM to backup (PR [#3479](https://github.com/vatesfr/xen-orchestra/pull/3479))
+
 ### Released packages
 
 - xo-server v5.28.0

packages/xo-server/src/xo-mixins/backups-ng/index.js

@@ -9,10 +9,11 @@ import { type Pattern, createPredicate } from 'value-matcher'
 import { type Readable, PassThrough } from 'stream'
 import { AssertionError } from 'assert'
 import { basename, dirname } from 'path'
+import { NULL_REF } from 'xen-api'
 import {
   countBy,
   flatMap,
-  forEach,
+  forOwn,
   groupBy,
   isEmpty,
   last,
@@ -1135,6 +1136,13 @@ export default class BackupNg {
         const fullRequired = { __proto__: null }
         const vdis: $Dict<Vdi> = getVmDisks(baseSnapshot)
 
+        // ignore VDI snapshots which no longer have a parent
+        forOwn(vdis, (vdi, key, vdis) => {
+          if (vdi.snapshot_of === NULL_REF) {
+            delete vdis[key]
+          }
+        })
+
         for (const { $id: srId, xapi } of srs) {
           const replicatedVm = listReplicatedVms(
             xapi,
@@ -1151,7 +1159,7 @@ export default class BackupNg {
             getVmDisks(replicatedVm),
             vdi => vdi.other_config[TAG_COPY_SRC]
           )
-          forEach(vdis, vdi => {
+          forOwn(vdis, vdi => {
             if (!(vdi.uuid in replicatedVdis)) {
               fullRequired[vdi.$snapshot_of.$id] = true
             }