From ecfed30e6ed2816994dcf9f17be1e774751bbd50 Mon Sep 17 00:00:00 2001
From: Julien Fontanet <julien.fontanet@isonoe.net>
Date: Thu, 28 Mar 2019 10:05:15 +0100
Subject: [PATCH] fix(xo-web/JSON schema object input): clear when un-use
 (#4076)

---
 CHANGELOG.unreleased.md                               |  1 +
 .../src/common/json-schema-input/object-input.js      | 11 ++++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index 06f02f367..8b0373858 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -13,6 +13,7 @@
 - [Remotes] Fixes `spawn mount EMFILE` error during backup
 - Properly redirect to sign in page instead of being stuck in a refresh loop
 - [Backup-ng] No more false positives when list matching VMs on Home page [#4078](https://github.com/vatesfr/xen-orchestra/issues/4078) (PR [#4085](https://github.com/vatesfr/xen-orchestra/pull/4085))
+- [Plugins] Properly remove optional settings when unchecking _Fill information_ (PR [#4076](https://github.com/vatesfr/xen-orchestra/pull/4076))
 
 ### Released packages
 
diff --git a/packages/xo-web/src/common/json-schema-input/object-input.js b/packages/xo-web/src/common/json-schema-input/object-input.js
index 352d92b11..f1c5bc1a5 100644
--- a/packages/xo-web/src/common/json-schema-input/object-input.js
+++ b/packages/xo-web/src/common/json-schema-input/object-input.js
@@ -6,6 +6,7 @@ import { keyBy, map } from 'lodash'
 
 import _ from '../intl'
 import Component from '../base-component'
+import getEventValue from '../get-event-value'
 import { EMPTY_OBJECT } from '../utils'
 
 import GenericInput from './generic-input'
@@ -33,6 +34,14 @@ export default class ObjectInput extends Component {
     })
   }
 
+  _onUseChange = event => {
+    const use = getEventValue(event)
+    if (!use) {
+      this.props.onChange()
+    }
+    this.setState({ use })
+  }
+
   _getRequiredProps = createSelector(
     () => this.props.schema.required,
     required => (required ? keyBy(required) : EMPTY_OBJECT)
@@ -67,7 +76,7 @@ export default class ObjectInput extends Component {
               <input
                 checked={use}
                 disabled={disabled}
-                onChange={this.linkState('use')}
+                onChange={this._onUseChange}
                 type='checkbox'
               />{' '}
               {_('fillOptionalInformations')}