fix(xo-server/metadata): missing Xapis should trigger a failure job (#4283)

Fixes #4281

CHANGELOG.unreleased.md

@@ -7,7 +7,10 @@
 
 ### Bug fixes
 
+- [Metadata backup] Missing XAPIs should trigger a failure job [#4281](https://github.com/vatesfr/xen-orchestra/issues/4281) (PR [#4283](https://github.com/vatesfr/xen-orchestra/pull/4283))
+
 ### Released packages
 
+- xo-server-backup-reports v0.16.2
 - xo-server v5.44.0
 - xo-web v5.44.0

packages/xo-server-backup-reports/src/index.js

@@ -142,12 +142,14 @@ const getErrorMarkdown = task => {
 
 const MARKDOWN_BY_TYPE = {
   pool(task, { formatDate }) {
-    const { pool, poolMaster = {} } = task.data
+    const { id, pool = {}, poolMaster = {} } = task.data
     const name = pool.name_label || poolMaster.name_label || UNKNOWN_ITEM
 
     return {
       body: [
-        `- **UUID**: ${pool.uuid}`,
+        pool.uuid !== undefined
+          ? `- **UUID**: ${pool.uuid}`
+          : `- **ID**: ${id}`,
         ...getTemporalDataMarkdown(task.end, task.start, formatDate),
         getErrorMarkdown(task),
       ],

packages/xo-server/src/xo-mixins/backups-ng-logs.js

@@ -1,10 +1,8 @@
 import ms from 'ms'
 import { forEach, isEmpty, iteratee, sortedIndexBy } from 'lodash'
-import { noSuchObject } from 'xo-common/api-errors'
 
 const isSkippedError = error =>
   error.message === 'no disks found' ||
-  noSuchObject.is(error) ||
   error.message === 'no VMs match this pattern' ||
   error.message === 'unhealthy VDI chain'
 

packages/xo-server/src/xo-mixins/metadata-backups.js

@@ -43,6 +43,20 @@ type MetadataBackupJob = {
   xoMetadata?: boolean,
 }
 
+const logInstantFailureTask = (logger, { data, error, message, parentId }) => {
+  const taskId = logger.notice(message, {
+    data,
+    event: 'task.start',
+    parentId,
+  })
+  logger.error(message, {
+    event: 'task.end',
+    result: serializeError(error),
+    status: 'failure',
+    taskId,
+  })
+}
+
 const createSafeReaddir = (handler, methodName) => (path, options) =>
   handler.list(path, options).catch(error => {
     if (error?.code !== 'ENOENT') {
@@ -97,7 +111,7 @@ const deleteOldBackups = (handler, dir, retention, handleError) =>
 // Task logs emitted in a metadata backup execution:
 //
 // job.start(data: { reportWhen: ReportWhen })
-// ├─ task.start(data: { type: 'pool', id: string, pool: <Pool />, poolMaster: <Host /> })
+// ├─ task.start(data: { type: 'pool', id: string, pool?: <Pool />, poolMaster?: <Host /> })
 // │  ├─ task.start(data: { type: 'remote', id: string })
 // │  │  └─ task.end
 // │  └─ task.end
@@ -527,16 +541,15 @@ export default class metadataBackup {
         try {
           xapi = this._app.getXapi(id)
         } catch (error) {
-          logger.warning(
+          logInstantFailureTask(logger, {
-            `unable to get the xapi associated to the pool (${id})`,
+            data: {
-            {
+              type: 'pool',
-              event: 'task.warning',
+              id,
-              taskId: runJobId,
+            },
-              data: {
+            error,
-                error,
+            message: `unable to get the xapi associated to the pool (${id})`,
-              },
+            parentId: runJobId,
-            }
+          })
-          )
         }
         if (xapi !== undefined) {
           promises.push(