From fc81cf4d709d1f84905266120494c411ee83edf0 Mon Sep 17 00:00:00 2001
From: Nicolas Raynaud <github@nraynaud.com>
Date: Fri, 2 Oct 2020 11:38:18 +0200
Subject: [PATCH] fix(xo-web/remotes): fix S3 secret key edit UI (#5305)

Fixes #5233
---
 CHANGELOG.unreleased.md                               | 1 +
 packages/xo-web/src/xo-app/settings/remotes/remote.js | 9 ++++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index 3f9450156..12adba2ed 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -14,6 +14,7 @@
 > Users must be able to say: “I had this issue, happy to know it's fixed”
 
 - [XOA/Notifications] Don't show expired notifications (PR [#5304](https://github.com/vatesfr/xen-orchestra/pull/5304))
+- [Backup/S3] Fix secret key edit form [#5233](https://github.com/vatesfr/xen-orchestra/issues/5233) (PR[#5305](https://github.com/vatesfr/xen-orchestra/pull/5305))
 
 ### Packages to release
 
diff --git a/packages/xo-web/src/xo-app/settings/remotes/remote.js b/packages/xo-web/src/xo-app/settings/remotes/remote.js
index bf3db021e..a96fbb708 100644
--- a/packages/xo-web/src/xo-app/settings/remotes/remote.js
+++ b/packages/xo-web/src/xo-app/settings/remotes/remote.js
@@ -139,6 +139,9 @@ export default decorate([
           .then(reset)
           .catch(err => error('Create Remote', err.message || String(err)))
       },
+      setSecretKey(_, { target: { value } }) {
+        this.state.password = value
+      },
     },
     computed: {
       formId: generateId,
@@ -414,11 +417,11 @@ export default decorate([
                 <input
                   className='form-control'
                   name='password'
-                  onChange={effects.linkState}
-                  placeholder='Secret access key'
+                  onChange={effects.setSecretKey}
+                  placeholder='Paste secret here to change it'
+                  autoComplete='off'
                   required
                   type='text'
-                  value={password}
                 />
               </div>
             </fieldset>