fix(Xapi#_assertHealthyVdiChain): fix for NFS SR prior XS 7.1 (#568)

Fixes vatesfr/xo-web#2207

src/xapi/index.js

@@ -12,6 +12,7 @@ import {
   find,
   filter,
   flatten,
+  groupBy,
   includes,
   isEmpty,
   omit,
@@ -777,26 +778,30 @@ export default class Xapi extends XapiBase {
     })
   }
 
-  _assertHealthyVdiChain (vdi) {
+  _assertHealthyVdiChain (vdi, childrenMap) {
     if (vdi == null) {
       return
     }
 
     if (!vdi.managed) {
-      let n = 0
-      const { uuid } = vdi
-      forEach(vdi.$SR.$VDIs, vdi => {
-        if (vdi.sm_config['vhd-parent'] === uuid && ++n > 1) {
-          return false // no need to continue, more than 1 child
+      if (childrenMap === undefined) {
+        childrenMap = groupBy(vdi.$SR.$VDIs, _ => _.sm_config['vhd-parent'])
       }
-      })
-      if (n === 1) {
+
+      // an unmanaged VDI should not have exactly one child: they
+      // should coalesce
+      const children = childrenMap[vdi.uuid]
+      if (
+        children.length === 1 &&
+        !children[0].managed // some SRs do not coalesce the leaf
+      ) {
         throw new Error('unhealthy VDI chain')
       }
     }
 
     this._assertHealthyVdiChain(
-      this.getObjectByUuid(vdi.sm_config['vhd-parent'], null)
+      this.getObjectByUuid(vdi.sm_config['vhd-parent'], null),
+      childrenMap
     )
   }