Change API for PdmObjectHandle and PdmFieldHandle

* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
This commit is contained in:
Magne Sjaastad
2023-05-12 21:41:34 +02:00
committed by GitHub
parent 37e29a0f68
commit 0c90f67dcc
510 changed files with 1651 additions and 3111 deletions

View File

@@ -926,9 +926,7 @@ RimWellPath* RimStimPlanModel::wellPath() const
const caf::PdmObjectHandle* objHandle = dynamic_cast<const caf::PdmObjectHandle*>( this );
if ( !objHandle ) return nullptr;
RimWellPath* wellPath = nullptr;
objHandle->firstAncestorOrThisOfType( wellPath );
return wellPath;
return objHandle->firstAncestorOrThisOfType<RimWellPath>();
}
//--------------------------------------------------------------------------------------------------
@@ -1301,8 +1299,7 @@ QString RimStimPlanModel::underburdenFacies() const
void RimStimPlanModel::updateReferringPlots()
{
// Update plots referring to this fracture model
std::vector<RimStimPlanModelPlot*> referringObjects;
objectsWithReferringPtrFieldsOfType( referringObjects );
std::vector<RimStimPlanModelPlot*> referringObjects = objectsWithReferringPtrFieldsOfType<RimStimPlanModelPlot>();
for ( auto modelPlot : referringObjects )
{
@@ -1551,8 +1548,7 @@ void RimStimPlanModel::stimPlanModelTemplateChanged( const caf::SignalEmitter* e
//--------------------------------------------------------------------------------------------------
void RimStimPlanModel::updateViewsAndPlots()
{
RimEclipseCase* eclipseCase = nullptr;
this->firstAncestorOrThisOfType( eclipseCase );
auto eclipseCase = firstAncestorOrThisOfType<RimEclipseCase>();
if ( eclipseCase )
{
RiaCompletionTypeCalculationScheduler::instance()->scheduleRecalculateCompletionTypeAndRedrawAllViews( { eclipseCase } );