Catch roff parse errors when checking for grid data

ApplicationLibCode/FileInterface/RifRoffFileTools.cpp

@@ -666,18 +666,26 @@ bool RifRoffFileTools::hasGridData( const QString& filename )
         return false;
     }
 
-    roff::Reader reader( stream );
+    try
-    reader.parse();
+    {
+        roff::Reader reader( stream );
+        reader.parse();
 
-    const std::vector<std::pair<std::string, roff::Token::Kind>> arrayTypes = reader.getNamedArrayTypes();
+        const std::vector<std::pair<std::string, roff::Token::Kind>> arrayTypes = reader.getNamedArrayTypes();
 
-    const std::string cornerLinesDataKeyword = "cornerLines" + roff::Parser::postFixData();
+        const std::string cornerLinesDataKeyword = "cornerLines" + roff::Parser::postFixData();
-    auto              cornerLinesDataItr     = std::find_if( arrayTypes.begin(),
+        auto              cornerLinesDataItr     = std::find_if( arrayTypes.begin(),
-                                            arrayTypes.end(),
+                                                arrayTypes.end(),
-                                            [&cornerLinesDataKeyword]( const auto& arrayType )
+                                                [&cornerLinesDataKeyword]( const auto& arrayType )
-                                            { return arrayType.first == cornerLinesDataKeyword; } );
+                                                { return arrayType.first == cornerLinesDataKeyword; } );
 
-    return cornerLinesDataItr != arrayTypes.end();
+        return cornerLinesDataItr != arrayTypes.end();
+    }
+    catch ( std::runtime_error& err )
+    {
+        RiaLogging::error( std::format( "Roff file parsing failed: {}", err.what() ) );
+        return false;
+    }
 }
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/UnitTests/RifRoffFileTools-Test.cpp

@@ -16,6 +16,7 @@
 
 #include <QDir>
 #include <QFile>
+#include <QTemporaryDir>
 
 #include <algorithm>
 #include <cmath>
@@ -179,6 +180,20 @@ TEST( RifRoffFileTools, HasGridDataFalseForMissingFile )
     EXPECT_FALSE( RifRoffFileTools::hasGridData( filePath ) );
 }
 
+TEST( RifRoffFileTools, HasGridDataFalseForMalformedFile )
+{
+    QTemporaryDir tempDir;
+    ASSERT_TRUE( tempDir.isValid() );
+
+    auto  filePath = tempDir.filePath( "malformed.roff" );
+    QFile file( filePath );
+    ASSERT_TRUE( file.open( QIODevice::WriteOnly ) );
+    file.write( "this is not a roff file" );
+    file.close();
+
+    EXPECT_FALSE( RifRoffFileTools::hasGridData( filePath ) );
+}
+
 //--------------------------------------------------------------------------------------------------
 // openGridFile on a stream is the entry point used when the roff data is not a file on disk, e.g. a
 // blob downloaded from Sumo.