Polygon updates (#11298)

* Make menus similar for polygon and polygonInView
* Crash fix: Iterator might be invalidated by erase, reorder operations.
* Update pick editor after reload
* Do not enable edit if polygon is read only
* Make sure filter and intersection geometry is updated after a reload
* Make sure other pick editors are updated when polygon in view is changed

ApplicationLibCode/ProjectDataModel/Polygons/RimPolygonInViewCollection.cpp

@@ -123,6 +123,14 @@ void RimPolygonInViewCollection::fieldChangedByUi( const caf::PdmFieldHandle* ch
     }
 }
 
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+void RimPolygonInViewCollection::appendMenuItems( caf::CmdFeatureMenuBuilder& menuBuilder ) const
+{
+    RimPolygonCollection::appendPolygonMenuItems( menuBuilder );
+}
+
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------
@@ -222,8 +230,8 @@ void RimPolygonInViewCollection::syncPolygonsWithView()
         if ( it != existingPolygonsInView.end() )
         {
             newPolygonsInView.push_back( *it );
-            existingPolygonsInView.erase( it );
             ( *it )->updateTargetsFromPolygon();
+            existingPolygonsInView.erase( it );
         }
         else
         {