clang-19-tidy and clang-19-format fixes

GrpcInterface/RiaGrpcAppService.cpp

@@ -67,7 +67,7 @@ grpc::Status
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcAppService::createCallbacks()
 {
-    typedef RiaGrpcAppService Self;
+    using Self = RiaGrpcAppService;
     return { new RiaGrpcUnaryCallback<Self, rips::Empty, rips::Version>( this, &Self::GetVersion, &Self::RequestGetVersion ),
              new RiaGrpcUnaryCallback<Self, rips::Empty, rips::Empty>( this, &Self::Exit, &Self::RequestExit ),
              new RiaGrpcUnaryCallback<Self, rips::Empty, rips::RuntimeInfo>( this,

GrpcInterface/RiaGrpcCaseService.cpp

@@ -727,7 +727,7 @@ grpc::Status RiaGrpcCaseService::GetCoarseningInfoArray( grpc::ServerContext*
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcCaseService::createCallbacks()
 {
-    typedef RiaGrpcCaseService Self;
+    using Self = RiaGrpcCaseService;
 
     return { new RiaGrpcUnaryCallback<Self, CaseRequest, GridCount>( this, &Self::GetGridCount, &Self::RequestGetGridCount ),
              new RiaGrpcUnaryCallback<Self, CellInfoRequest, CellCount>( this, &Self::GetCellCount, &Self::RequestGetCellCount ),

GrpcInterface/RiaGrpcCommandService.cpp

@@ -104,7 +104,7 @@ grpc::Status RiaGrpcCommandService::Execute( grpc::ServerContext* context, const
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcCommandService::createCallbacks()
 {
-    typedef RiaGrpcCommandService Self;
+    using Self = RiaGrpcCommandService;
 
     return { new RiaGrpcUnaryCallback<Self, CommandParams, CommandReply>( this, &Self::Execute, &Self::RequestExecute ) };
 }

GrpcInterface/RiaGrpcGridService.cpp

@@ -187,7 +187,7 @@ grpc::Status RiaGrpcGridService::GetCellCorners( grpc::ServerContext*       cont
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcGridService::createCallbacks()
 {
-    typedef RiaGrpcGridService Self;
+    using Self = RiaGrpcGridService;
 
     return {
 

GrpcInterface/RiaGrpcKeyValueStoreService.cpp

@@ -169,7 +169,7 @@ grpc::Status RiaGrpcKeyValueStoreService::SetValue( grpc::ServerContext*
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcKeyValueStoreService::createCallbacks()
 {
-    typedef RiaGrpcKeyValueStoreService Self;
+    using Self = RiaGrpcKeyValueStoreService;
 
     std::vector<RiaGrpcCallbackInterface*> callbacks;
     callbacks = {

GrpcInterface/RiaGrpcNNCPropertiesService.cpp

@@ -491,7 +491,7 @@ grpc::Status RiaGrpcNNCPropertiesService::SetNNCValues( grpc::ServerContext*
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcNNCPropertiesService::createCallbacks()
 {
-    typedef RiaGrpcNNCPropertiesService Self;
+    using Self = RiaGrpcNNCPropertiesService;
 
     std::vector<RiaGrpcCallbackInterface*> callbacks;
     callbacks =

GrpcInterface/RiaGrpcPdmObjectService.cpp

@@ -553,7 +553,12 @@ grpc::Status RiaGrpcPdmObjectService::CallPdmObjectMethod( grpc::ServerContext*
         {
             copyPdmObjectFromRipsToCaf( &( request->params() ), method.get() );
 
-            std::expected<caf::PdmObjectHandle*, QString> result = method->execute();
+            // clang-tidy-19 has a bug that did the following:
+            //   std::expected<caf::PdmObjectHandle, QString> result = method->execute();
+            // was replaced with
+            //   std::unexpected<caf::PdmObjectHandle, QString> result = method->execute();
+            // Using auto works around the problem
+            auto result = method->execute();
             if ( !result.has_value() )
             {
                 RiaLogging::error( QString( "Method '%1' failed. Error: %2" ).arg( methodKeyword ).arg( result.error() ) );
@@ -589,7 +594,7 @@ grpc::Status RiaGrpcPdmObjectService::CallPdmObjectMethod( grpc::ServerContext*
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcPdmObjectService::createCallbacks()
 {
-    typedef RiaGrpcPdmObjectService Self;
+    using Self = RiaGrpcPdmObjectService;
     return {
         new RiaGrpcUnaryCallback<Self, PdmParentObjectRequest, PdmObject>( this,
                                                                            &Self::GetAncestorPdmObject,

GrpcInterface/RiaGrpcProjectService.cpp

@@ -208,7 +208,7 @@ grpc::Status
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcProjectService::createCallbacks()
 {
-    typedef RiaGrpcProjectService Self;
+    using Self = RiaGrpcProjectService;
 
     return { new RiaGrpcUnaryCallback<Self, Empty, CaseRequest>( this, &Self::GetCurrentCase, &Self::RequestGetCurrentCase ),
              new RiaGrpcUnaryCallback<Self, Empty, CaseInfoArray>( this,

GrpcInterface/RiaGrpcPropertiesService.cpp

@@ -485,7 +485,7 @@ grpc::Status RiaGrpcPropertiesService::SetGridProperty( grpc::ServerContext*
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcPropertiesService::createCallbacks()
 {
-    typedef RiaGrpcPropertiesService Self;
+    using Self = RiaGrpcPropertiesService;
 
     std::vector<RiaGrpcCallbackInterface*> callbacks;
     callbacks =

GrpcInterface/RiaGrpcSimulationWellService.cpp

@@ -170,7 +170,7 @@ cvf::ref<RigSimWellData> RiaGrpcSimulationWellService::findWellResult( const Rim
 //--------------------------------------------------------------------------------------------------
 std::vector<RiaGrpcCallbackInterface*> RiaGrpcSimulationWellService::createCallbacks()
 {
-    typedef RiaGrpcSimulationWellService Self;
+    using Self = RiaGrpcSimulationWellService;
 
     return {
         new RiaGrpcUnaryCallback<Self, SimulationWellRequest, SimulationWellStatus>( this,