OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-02-25 18:55:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

#3967 Use empty() and const ref

Browse Source
This commit is contained in:
Magne Sjaastad 2019-01-16 12:53:30 +01:00
parent 8e307399c0
commit 488d62522b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ApplicationCode/Application/Tools/RiaArgumentParser.cpp
View File

@ -123,7 +123,7 @@ bool RiaArgumentParser::parseArguments()
// If positional parameter functionality is to be supported, the test for existence of positionalParameters must be removed // If positional parameter functionality is to be supported, the test for existence of positionalParameters must be removed
// This is based on a pull request by @andlaus https://github.com/OPM/ResInsight/pull/162 // This is based on a pull request by @andlaus https://github.com/OPM/ResInsight/pull/162
if (!parseOk || progOpt.hasOption("help") || progOpt.hasOption("?") || progOpt.positionalParameters().size() > 0) if (!parseOk || progOpt.hasOption("help") || progOpt.hasOption("?") || !progOpt.positionalParameters().empty())
{ {
#if defined(_MSC_VER) && defined(_WIN32) #if defined(_MSC_VER) && defined(_WIN32)
RiaApplication::instance()->showFormattedTextInMessageBox(helpText); RiaApplication::instance()->showFormattedTextInMessageBox(helpText);
@ -253,7 +253,7 @@ bool RiaArgumentParser::parseArguments()
std::vector<QString> gridFileNames = std::vector<QString> gridFileNames =
RiaApplication::readFileListFromTextFile(cvfqt::Utils::toQString(o.safeValue(optionIdx++))); RiaApplication::readFileListFromTextFile(cvfqt::Utils::toQString(o.safeValue(optionIdx++)));
if (groupId != -1 && gridFileNames.size() > 0) if (groupId != -1 && !gridFileNames.empty())
{ {
projectModifier->setReplaceSourceCasesById(groupId, gridFileNames); projectModifier->setReplaceSourceCasesById(groupId, gridFileNames);
} }
@ -306,13 +306,13 @@ bool RiaArgumentParser::parseArguments()
bool snapshotPlots = false; bool snapshotPlots = false;
QStringList snapshotItemTexts = cvfqt::Utils::toQStringList(o.values()); QStringList snapshotItemTexts = cvfqt::Utils::toQStringList(o.values());
if (snapshotItemTexts.size() == 0) if (snapshotItemTexts.empty())
{ {
// No options will keep backwards compatibility before we introduced snapshot of plots // No options will keep backwards compatibility before we introduced snapshot of plots
snapshotViews = true; snapshotViews = true;
} }
for (QString s : snapshotItemTexts) for (const QString& s : snapshotItemTexts)
{ {
if (s.toLower() == "all") if (s.toLower() == "all")
{ {