OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-02-25 18:55:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add readability-simplify-boolean-expr

Browse Source 
* Add readability-simplify-boolean-expr
* Fixes based on review
This commit is contained in:
Magne Sjaastad
2023-06-26 13:12:41 +02:00
committed by GitHub
parent 34d83efaed
commit 59ca0b943c
116 changed files with 179 additions and 635 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensAutoExportToSharingServerFeature.cpp
View File

@@ -137,12 +137,5 @@ bool RicHoloLensAutoExportToSharingServerFeature::isCommandChecked()
bool RicHoloLensAutoExportToSharingServerFeature::isSessionValid() const
{
RicHoloLensSession* session = RicHoloLensSessionManager::instance()->session();
if ( session && session->isSessionValid() )
{
return true;
}
else
{
return false;
}
return session && session->isSessionValid();
}

2
ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensCreateDummyFileBackedSessionFeature.cpp
View File

@@ -29,7 +29,7 @@ CAF_CMD_SOURCE_INIT( RicHoloLensCreateDummyFiledBackedSessionFeature, "RicHoloLe
//--------------------------------------------------------------------------------------------------
bool RicHoloLensCreateDummyFiledBackedSessionFeature::isCommandEnabled()
{
return RicHoloLensSessionManager::instance()->session() ? false : true;
return RicHoloLensSessionManager::instance()->session() == nullptr;
}
//--------------------------------------------------------------------------------------------------

2
ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensCreateSessionFeature.cpp
View File

@@ -36,7 +36,7 @@ CAF_CMD_SOURCE_INIT( RicHoloLensCreateSessionFeature, "RicHoloLensCreateSessionF
//--------------------------------------------------------------------------------------------------
bool RicHoloLensCreateSessionFeature::isCommandEnabled()
{
return RicHoloLensSessionManager::instance()->session() ? false : true;
return RicHoloLensSessionManager::instance()->session() == nullptr;
}
//--------------------------------------------------------------------------------------------------

9
ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensExportToSharingServerFeature.cpp
View File

@@ -35,14 +35,7 @@ CAF_CMD_SOURCE_INIT( RicHoloLensExportToSharingServerFeature, "RicHoloLensExport
bool RicHoloLensExportToSharingServerFeature::isCommandEnabled()
{
RicHoloLensSession* session = RicHoloLensSessionManager::instance()->session();
if ( session && session->isSessionValid() )
{
return true;
}
else
{
return false;
}
return session && session->isSessionValid();
}
//--------------------------------------------------------------------------------------------------

2
ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensTerminateSessionFeature.cpp
View File

@@ -34,7 +34,7 @@ CAF_CMD_SOURCE_INIT( RicHoloLensTerminateSessionFeature, "RicHoloLensTerminateSe
//--------------------------------------------------------------------------------------------------
bool RicHoloLensTerminateSessionFeature::isCommandEnabled()
{
return RicHoloLensSessionManager::instance()->session() ? true : false;
return RicHoloLensSessionManager::instance()->session() != nullptr;
}
//--------------------------------------------------------------------------------------------------

9
ApplicationLibCode/Commands/HoloLensCommands/VdeArrayDataPacket.cpp
View File

@@ -70,14 +70,7 @@ VdeArrayDataPacket::VdeArrayDataPacket()
//--------------------------------------------------------------------------------------------------
bool VdeArrayDataPacket::isValid() const
{
if ( m_elementType != Unknown && m_packetBytes.size() >= VDE_HEADER_SIZE && m_arrayId >= 0 )
{
return true;
}
else
{
return false;
}
return m_elementType != Unknown && m_packetBytes.size() >= VDE_HEADER_SIZE && m_arrayId >= 0;
}
//--------------------------------------------------------------------------------------------------

7
ApplicationLibCode/Commands/HoloLensCommands/VdeFileExporter.cpp
View File

@@ -91,12 +91,7 @@ bool VdeFileExporter::exportViewContents( const RimGridView& view )
VdePacketDirectory packetDirectory;
extractor.extractViewContents( &modelMetaJsonStr, &allReferencedArrayIds, &packetDirectory );
if ( !exportToFile( modelMetaJsonStr, packetDirectory, allReferencedArrayIds ) )
{
return false;
}
return true;
return exportToFile( modelMetaJsonStr, packetDirectory, allReferencedArrayIds );
}
//--------------------------------------------------------------------------------------------------