Add readability-simplify-boolean-expr

* Add readability-simplify-boolean-expr
* Fixes based on review
This commit is contained in:
Magne Sjaastad
2023-06-26 13:12:41 +02:00
committed by GitHub
parent 34d83efaed
commit 59ca0b943c
116 changed files with 179 additions and 635 deletions

View File

@@ -61,9 +61,7 @@ bool RicPasteEclipseCasesFeature::isCommandEnabled()
caf::PdmObjectHandle* destinationObject = dynamic_cast<caf::PdmObjectHandle*>( caf::SelectionManager::instance()->selectedItem() );
RimIdenticalGridCaseGroup* gridCaseGroup = RicPasteFeatureImpl::findGridCaseGroup( destinationObject );
if ( gridCaseGroup ) return true;
return false;
return gridCaseGroup != nullptr;
}
//--------------------------------------------------------------------------------------------------

View File

@@ -60,9 +60,7 @@ bool RicPasteEclipseViewsFeature::isCommandEnabled()
if ( gridCaseGroup ) return false;
RimEclipseCase* eclipseCase = RicPasteFeatureImpl::findEclipseCase( destinationObject );
if ( eclipseCase ) return true;
return false;
return eclipseCase != nullptr;
}
//--------------------------------------------------------------------------------------------------

View File

@@ -54,9 +54,7 @@ bool RicPasteGeoMechViewsFeature::isCommandEnabled()
caf::PdmObjectHandle* destinationObject = dynamic_cast<caf::PdmObjectHandle*>( caf::SelectionManager::instance()->selectedItem() );
RimGeoMechCase* geoMechCase = RicPasteFeatureImpl::findGeoMechCase( destinationObject );
if ( geoMechCase ) return true;
return false;
return geoMechCase != nullptr;
}
//--------------------------------------------------------------------------------------------------

View File

@@ -54,12 +54,7 @@ bool RicPasteIntersectionsFeature::isCommandEnabled()
caf::PdmObjectHandle* destinationObject = dynamic_cast<caf::PdmObjectHandle*>( caf::SelectionManager::instance()->selectedItem() );
if ( findIntersectionCollection( destinationObject ) )
{
return true;
}
return false;
return findIntersectionCollection( destinationObject ) != nullptr;
}
//--------------------------------------------------------------------------------------------------